New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOMDocument can be disabled #241

Closed
nacin opened this Issue Sep 25, 2012 · 2 comments

Comments

Projects
None yet
2 participants
@nacin

nacin commented Sep 25, 2012

DOMDocument is enabled by default, but can be disabled with --disable-dom, or by an overzealous distro. This poses serious problems for widely distributed/deployed software that uses SimplePie and needs to work on as many environments as possible.

Was not a problem with SimplePie 1.2.

@nacin

This comment has been minimized.

Show comment
Hide comment
@nacin

nacin Sep 25, 2012

Downstream: http://core.trac.wordpress.org/ticket/21990. This is a blocker for WordPress.

nacin commented Sep 25, 2012

Downstream: http://core.trac.wordpress.org/ticket/21990. This is a blocker for WordPress.

@rmccue rmccue closed this in e33d744 Oct 13, 2012

rmccue added a commit that referenced this issue Oct 13, 2012

Generate an error if DOMDocument doesn't exist
Rather than trying to load the class and getting a failure, this much more
sensibly generates an error. Fixes #241

Also introduces SimplePie_Exception, which is only used internally.

@rmccue rmccue reopened this Nov 21, 2012

@rmccue

This comment has been minimized.

Show comment
Hide comment
@rmccue

rmccue Nov 21, 2012

Contributor

This is still occurring, as one instance of this was missed.

Contributor

rmccue commented Nov 21, 2012

This is still occurring, as one instance of this was missed.

rmccue added a commit that referenced this issue Dec 2, 2012

If DOMDocument doesn't exist, nicely fail Sanitize
See #241. This fixes it for 1.3.2, but requires different changes for 1.4.

@rmccue rmccue closed this in 16b8e8e Dec 2, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment