Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

DOMDocument can be disabled #241

Closed
nacin opened this Issue · 2 comments

2 participants

@nacin

DOMDocument is enabled by default, but can be disabled with --disable-dom, or by an overzealous distro. This poses serious problems for widely distributed/deployed software that uses SimplePie and needs to work on as many environments as possible.

Was not a problem with SimplePie 1.2.

@nacin

Downstream: http://core.trac.wordpress.org/ticket/21990. This is a blocker for WordPress.

@rmccue rmccue closed this issue from a commit
@rmccue rmccue Generate an error if DOMDocument doesn't exist
Rather than trying to load the class and getting a failure, this much more
sensibly generates an error. Fixes #241

Also introduces SimplePie_Exception, which is only used internally.
e33d744
@rmccue rmccue closed this in e33d744
@rmccue rmccue referenced this issue from a commit
@rmccue rmccue Generate an error if DOMDocument doesn't exist
Rather than trying to load the class and getting a failure, this much more
sensibly generates an error. Fixes #241

Also introduces SimplePie_Exception, which is only used internally.
f0e144e
@rmccue rmccue reopened this
@rmccue
Owner

This is still occurring, as one instance of this was missed.

@skyzyx skyzyx referenced this issue from a commit in skyzyx/simplepie
@rmccue rmccue Generate an error if DOMDocument doesn't exist
Rather than trying to load the class and getting a failure, this much more
sensibly generates an error. Fixes #241

Also introduces SimplePie_Exception, which is only used internally.
255847d
@rmccue rmccue referenced this issue from a commit
@rmccue rmccue If DOMDocument doesn't exist, nicely fail Sanitize
See #241. This fixes it for 1.3.2, but requires different changes for 1.4.
1616001
@rmccue rmccue closed this issue from a commit
@rmccue rmccue Handle DOMDocument errors nicely when sanitizing
Fixes #241 for 1.4. Also introduces SimplePie::enable_exceptions() for better
error handling via progessive enhancement.
16b8e8e
@rmccue rmccue closed this in 16b8e8e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.