Quotes are removed from ETag headers #26

Closed
rmccue opened this Issue Sep 29, 2009 · 3 comments

Comments

Projects
None yet
2 participants
Contributor

rmccue commented Sep 29, 2009

Originally reported by Anonymous as issue 113

A header sent from teh servert like this:

ETag: "aae714dc9ba620a634334090ec80271e"

will get the quotes removed by SimplePie_HTTP_Parser. Those quotes are required according to http://www.w3.org/Protocols/rfc2616/rfc2616-sec3.html#sec3.11

However, some servers do not include them, and just adding them to the request If-None-Match header will confuse the server at the next request, and it will likely produce a 200 answer instead of a 304, even if there are no changes.

Examples of feeds that require the tag to be sent back exactly as it is received in order to obtain a correct 304 response:

http://feeds.feedburner.com/JewelryBlogFromJewelrymallcom (incorrectly sending the ETag without quotes)

http://jbrana.blogspot.com/feeds/posts/default (here, SimplePie incorrectly removes quotes)

Contributor

gsnedders commented Feb 18, 2010

@SimplePie_HTTP_Parser@ is horribly broken in so many ways…

Contributor

rmccue commented Feb 18, 2010

Agreed. We have 9 issues for it alone.

Contributor

rmccue commented Dec 12, 2010

Fixed in 6b9319f

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment