Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Wrong encoding returned for EUC-JP #38

Closed
rmccue opened this Issue · 6 comments

2 participants

@rmccue
Owner

Originally reported by Anonymous as issue 144

SimplePie_Misc::encoding('EUC-JP') should return EUC-JP, not Extended_UNIX_Code_Packed_Format_for_Japanese.

@gsnedders
Owner

Note that that function is programatically created by create.php.

@rmccue
Owner

EUC-JP is the preferred MIME name, however Extended_UNIX_Code_Fixed_Width_for_Japanese is the actual name. Which would be better in this case, gsnedders?

@gsnedders
Owner

EUC-JP should be returned as it is the preferred name (we should /always/ return the preferred name). This should, therefore, be fixed in create.php and regenerated, not by fixing it in the generated code (as this may happen with more than just EUC-JP).

@rmccue
Owner

Use EUC-JP as the preferred name in SimplePie_Misc::encoding(). Closed by 82aa6ca

@gsnedders
Owner

Um, that's not how to fix it at all. That's special casing it, as if we needed to break the file it's generated from.

@gsnedders
Owner

Really closed by simplepie/simplepie@9ad8882.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.