Use strict-comparison where possible #5

Open
rmccue opened this Issue Sep 29, 2009 · 1 comment

Projects

None yet

1 participant

Owner
rmccue commented Sep 29, 2009

Originally reported by Geoffrey Sneddon as issue 21

Work started on this in r944, but that only touched == and != leaving implicit comparison untouched (e.g., if ($var). This probably means searching through simplepie.inc for all if, for, and while statements. Not fun.

However lacking in excitement this is, it needs to be done — bugs have already slipped through because of this.

Owner
rmccue commented Dec 11, 2010

Fixed one instance of this in simplepie@478aeac

There are definitely instances of implicit loose comparison lurking around though, and I'll try and fix those tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment