New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use strict-comparison where possible #5

Closed
rmccue opened this Issue Sep 29, 2009 · 1 comment

Comments

Projects
None yet
2 participants
@rmccue
Contributor

rmccue commented Sep 29, 2009

Originally reported by Geoffrey Sneddon as issue 21

Work started on this in r944, but that only touched == and != leaving implicit comparison untouched (e.g., if ($var). This probably means searching through simplepie.inc for all if, for, and while statements. Not fun.

However lacking in excitement this is, it needs to be done — bugs have already slipped through because of this.

@rmccue

This comment has been minimized.

Contributor

rmccue commented Dec 11, 2010

Fixed one instance of this in 478aeac

There are definitely instances of implicit loose comparison lurking around though, and I'll try and fix those tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment