Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Memcache backend #147

Merged
merged 3 commits into from Sep 20, 2011

Conversation

Projects
None yet
2 participants
Contributor

mattrobenolt commented Jul 12, 2011

Adding a memcache backend, and also implemented a slightly different approach to "parse_DSN" to handle backends more generically. This leaves options for memcache, Redis, etc.

mattrobenolt added some commits Jul 12, 2011

@mattrobenolt mattrobenolt Implemented a more traditional URL based approach to specifying cachi…
…ng backends. Allows the format: [backend]://[user]:[pass]@[host]:[port][path]?[key=value]

This allows more flexibility for other backends other than the PDO based DSN format.
69bfec1
@mattrobenolt mattrobenolt MySQL backend implements proposed URL format. 92809db
@mattrobenolt mattrobenolt Added Memcache caching backend.
Implements format: memcache://127.0.0.1:11211?timeout=3600&prefix=simplepie_
5b9dbcd

@rmccue rmccue added a commit that referenced this pull request Sep 20, 2011

@rmccue rmccue Merge pull request #147 from mattrobenolt/master
Add Memcache backend. Some minor coding standards issues still to be fixed.
6201e67

@rmccue rmccue merged commit 6201e67 into simplepie:master Sep 20, 2011

Contributor

rmccue commented Sep 20, 2011

I think parse_str($params['query'], $params['options']); should be parse_str($params['query'], $params); instead, otherwise prefix and timeout will never get set for Memcache.

Can you confirm before I fix this?

Contributor

mattrobenolt commented Sep 20, 2011

Yeah, I think you might be right. Let me take a look at it tomorrow morning, and I'll fix it up. I think I just had something else in my head I was trying to do.

Contributor

mattrobenolt commented Sep 20, 2011

Ok, take a look at my fix: e424f3b

Contributor

rmccue commented Sep 20, 2011

Pushed, thanks!

Contributor

mattrobenolt commented Sep 20, 2011

No problem, I should have done more tests on my end before submitting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment