Updated deflater based on WordPress #182

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Contributor

sparksp commented Mar 22, 2012

I was getting lots of deflater warnings, this fixed it.

Updated deflater based on WordPress
Signed-off-by: Phill Sparks <me@phills.me.uk>
Contributor

rmccue commented Mar 24, 2012

WordPress is GPL-licensed, so we can't use code from it. It needs to be written from scratch.

@rmccue rmccue closed this Mar 24, 2012

Contributor

sparksp commented Mar 24, 2012

This was written from scratch; I was inspired by what I saw in WordPress' source. Please compare this with the http.php that I referenced (search for gzuncompress). I'm happy to recommit without mentioning WordPress if it makes you more comfortable about accepting the patch.

Contributor

rmccue commented Mar 25, 2012

Ah, as long as it's from scratch, that's fine!

In terms of coding standards though, can you put the comparisons at the end, and use parentheses around assignment? i.e. if (false !== $decompressed = gzinflate($this->body)) should be if (($decompressed = gzinflate($this->body)) !== false)

Thanks!

Contributor

sparksp commented Mar 26, 2012

Done and sent as a clean pull.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment