GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
As per nacin, the redefining of Cache::create() as static broke a bunch of stuff when subclassing. This should fix that.
To try and fix compatibility issues, add Cache::get_handler() This is now called instead of Cache::create(), *except* if the cache handler is registered via the legacy method.
Throw a E_USER_DEPRECATED error on old cache method
SimplePie will use get_handler() if the class is registered via the registry, or create() if created via set_cache_class(). For new cache handlers, they should be using the registry so that the class isn't marked as legacy.
Add tests for Cache classes
This should ensure that the correct methods are called.
Merge branch 'master' into cache-backwards-compat
Ignore E_NOTICE too
Apparently, this throws a notice, not a deprecated error. Who knew.
Add CacheTest to AllTests
Rather than changing error_reporting, just suppress
Hopefully this should fix tests on 5.4
Unfortunately, Travis is having some problems with their 5.2 builder, so it's not passing there. Can anyone confirm the tests pass on 5.2?
Merge pull request #243 from simplepie/cache-backwards-compat
Fix backwards compatibility with cache subclasses
Also fixed on one-dot-three: 9aa3385, f00f19c, 8b7ffd6, c2915d2, aafb99d, d029efb, e4920d1,