Permalink
2 comments
on commit
sign in to comment.
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
Be strict when checking return values.
- Loading branch information
Jaime Pérez Crespo
committed
Mar 2, 2018
1 parent
60b8d2b
commit 4f6af7f
Showing
1 changed file
with
1 addition
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4f6af7fThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please consider adding a comment here about the importance and meaning of the integer value
1. It appears to depend heavily on the return codes fromopenssl_verify()and is directly mentioned in two published security advisories: https://simplesamlphp.org/security/201802-01 and https://simplesamlphp.org/security/201803-014f6af7fThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the right place for that is the function's documentation in the library. I've created a PR for that. robrichards/xmlseclibs#168