diff --git a/lib/SimpleSAML/Utils/Crypto.php b/lib/SimpleSAML/Utils/Crypto.php index e9e229565d..c7d16921a5 100644 --- a/lib/SimpleSAML/Utils/Crypto.php +++ b/lib/SimpleSAML/Utils/Crypto.php @@ -404,8 +404,8 @@ public static function secureCompare($known, $user) return false; // length differs } $diff = 0; - for ($i = 0; $i < $len; ++$i) { - $diff |= $known[$i] ^ $user[$i]; + for ($i = 0; $i < $len; $i++) { + $diff |= ord($known[$i]) ^ ord($user[$i]); } // if all the bytes in $a and $b are identical, $diff should be equal to 0 return $diff === 0;