Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newUI: jquery-ui is not available #1020

Closed
tvdijen opened this issue Dec 16, 2018 · 7 comments
Closed

newUI: jquery-ui is not available #1020

tvdijen opened this issue Dec 16, 2018 · 7 comments
Milestone

Comments

@tvdijen
Copy link
Member

@tvdijen tvdijen commented Dec 16, 2018

I noticed tabs were broken on the newui because the jquery-ui functions are not available..
Now, this has been temporarily fixed by manually loading the old jquery-ui 529ace9 and 77fb41c..
Some further investigation learned me that, eventhough we have jquery-ui in our package.json, it needs to be exposed somehow in the webpack configuration..
Now, I know squat about Webpack and even with a bunch of howto's from the interwebz I couldn't get it to work, so help here is appreciated!

@tvdijen tvdijen added this to the 1.18 milestone Dec 16, 2018
@jaimeperez
Copy link
Member

@jaimeperez jaimeperez commented Jan 9, 2019

I don't think there's anything we do that justifies the dependency on jquery-ui, so I would actually prefer to stop using it completely and implementing tabs in some other way (like in the admin module)...

@tvdijen
Copy link
Member Author

@tvdijen tvdijen commented Jan 9, 2019

Ok, I think that would require us to modify the templates of discopower, oauth and statistics to use your alternative.

@jaimeperez
Copy link
Member

@jaimeperez jaimeperez commented Jan 9, 2019

Not urgent in any way though, I don't think we need to have that in place for 1.17. Your solution to add it back is perfectly fine 😉

@thijskh
Copy link
Member

@thijskh thijskh commented Mar 7, 2019

Agreed that it is fine to add it explicitly as it's still needed, and then migrate those components away from it.

@ghalse
Copy link
Contributor

@ghalse ghalse commented Mar 25, 2019

Ok, I think that would require us to modify the templates of consentAdmin, discopower and statistics to use your alternative.

A workaround that would allow you to stop shipping it with SSP simply for e.g. discopower would be to include it from code.jquery.com or another CDN only when it was required in those modules.

@tvdijen
Copy link
Member Author

@tvdijen tvdijen commented Mar 25, 2019

Since we're in the process of externalizing the modules, I think it's a good idea to include it there so our base repo is clean. Then we can create individual issues in the module-repos and they become someone else's problem :'D

@tvdijen
Copy link
Member Author

@tvdijen tvdijen commented May 27, 2019

All three modules mentioned above are now 1) externalized, 2) have their own copy of jQuery and 3) have their jQuery-version upgraded from 1.8 to 1.12.4.. It's a start!
Ideally we'd upgrade it up until the version included in the SSP base repository, but that work may continue in their individual repositories.

Leaving this issue open as a reminder that we can safely remove jQuery 1.8 from the repo for SSP 2.0. Therefore also moving the milestone to 2.0

@tvdijen tvdijen modified the milestones: 1.18, 2.0 May 27, 2019
@tvdijen tvdijen closed this in 2c8aa8a Feb 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants