New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newUI: jquery-ui is not available #1020

Open
tvdijen opened this Issue Dec 16, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@tvdijen
Copy link
Member

tvdijen commented Dec 16, 2018

I noticed tabs were broken on the newui because the jquery-ui functions are not available..
Now, this has been temporarily fixed by manually loading the old jquery-ui here and here..
Some further investigation learned me that, eventhough we have jquery-ui in our package.json, it needs to be exposed somehow in the webpack configuration..
Now, I know squat about Webpack and even with a bunch of howto's from the interwebz I couldn't get it to work, so help here is appreciated!

@tvdijen tvdijen added the help wanted label Dec 16, 2018

@tvdijen tvdijen added this to the 1.18 milestone Dec 16, 2018

@jaimeperez

This comment has been minimized.

Copy link
Member

jaimeperez commented Jan 9, 2019

I don't think there's anything we do that justifies the dependency on jquery-ui, so I would actually prefer to stop using it completely and implementing tabs in some other way (like in the admin module)...

@tvdijen

This comment has been minimized.

Copy link
Member

tvdijen commented Jan 9, 2019

Ok, I think that would require us to modify the templates of consentAdmin, discopower and statistics to use your alternative.

@jaimeperez

This comment has been minimized.

Copy link
Member

jaimeperez commented Jan 9, 2019

Not urgent in any way though, I don't think we need to have that in place for 1.17. Your solution to add it back is perfectly fine 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment