Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newUI: metadata-converter file upload looks broken (but is not) #1094

Open
tvdijen opened this Issue Apr 10, 2019 · 1 comment

Comments

Projects
None yet
1 participant
@tvdijen
Copy link
Member

tvdijen commented Apr 10, 2019

Describe the bug
metadata-converter file upload looks broken; the file is being processed, however 'No file selected' is still being displayed after selecting a file.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://your-idp.org/admin/metadata-converter.php
  2. Click on 'Or select a file'
  3. Pick a locally stored metadata XML file
  4. Nothing obvious is happening and the screen keeps saying 'No file selected'

Expected behavior
After picking / uploading a file, it should no longer say 'No file selected' but display the name of the file.

@tvdijen tvdijen added the bug label Apr 10, 2019

@tvdijen tvdijen added this to the 1.18 milestone Apr 10, 2019

@tvdijen

This comment has been minimized.

Copy link
Member Author

tvdijen commented Apr 10, 2019

I've taken a closer look and the issue is with the Twig-template hiding the and wrapping a pure-css button class around it to make it look pretty..
Showing the filename is part of the input-element that we're hiding and the only way I see to 'map' the filename on the label is to use Javascript..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.