Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cron module not working on web UI after PR #1181 #1220

Closed
klention opened this issue Oct 28, 2019 · 5 comments
Labels
bug
Milestone

Comments

@klention
Copy link

@klention klention commented Oct 28, 2019

Help us to keep this issue-tracker clean! For questions or support, please refer to our mailing lists

Describe the bug
After update to the last commit 4c7f8ff cron module does not work anymore when clicking Cron module information page link on web ui. From logs I can see the following error:
SimpleSAML\Error\Exception: Error 1 - Call to a member function render() on null at /var/simplesamlphp/lib/SimpleSAML/XHTML/Template.php:512

To Reproduce
Steps to reproduce the behavior:

  1. Update to latest commit on branch master
  2. Click on 'domain.com/simplesaml/module.php/cron/croninfo.php'
    Shows blank page.
@tvdijen

This comment has been minimized.

Copy link
Member

@tvdijen tvdijen commented Oct 28, 2019

Are you on old UI or new UI?

@tvdijen tvdijen added the needsinfo label Oct 28, 2019
@tvdijen

This comment has been minimized.

Copy link
Member

@tvdijen tvdijen commented Oct 28, 2019

My guess is that you're on the old UI...
What happens if you change send to show in this line?:

@klention

This comment has been minimized.

Copy link
Author

@klention klention commented Oct 28, 2019

My guess is that you're on the old UI...
What happens if you change send to show in this line?:

I am using the old UI.
When changing from send to show it displays OK on old UI.

I start using the new UI and change from show() to original value send() and it is working fine.
Thank you.

@klention klention closed this Oct 28, 2019
@tvdijen

This comment has been minimized.

Copy link
Member

@tvdijen tvdijen commented Oct 28, 2019

Leaving this open as a reminder..
I need to fix this case and perhaps a few more and make sure that new UI keeps working as well...

@tvdijen tvdijen reopened this Oct 28, 2019
@tvdijen tvdijen added bug and removed needsinfo labels Oct 28, 2019
@tvdijen tvdijen added this to the 1.19 milestone Oct 28, 2019
@tvdijen tvdijen changed the title Cron module not working on web UI after commit 4c7f8ff Cron module not working on web UI after PR #1181 Oct 28, 2019
@tvdijen

This comment has been minimized.

Copy link
Member

@tvdijen tvdijen commented Nov 9, 2019

Closed in 9bb75dd

@tvdijen tvdijen closed this Nov 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.