Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate support for SAML 1.1 #1267

Open
jaimeperez opened this issue Jan 7, 2020 · 5 comments
Open

Deprecate support for SAML 1.1 #1267

jaimeperez opened this issue Jan 7, 2020 · 5 comments
Milestone

Comments

@jaimeperez
Copy link
Member

@jaimeperez jaimeperez commented Jan 7, 2020

We should mark support for SAML 1.1 as deprecated in 1.19.

@jaimeperez jaimeperez added this to the 2.0 milestone Jan 7, 2020
@tvdijen

This comment has been minimized.

Copy link
Member

@tvdijen tvdijen commented Jan 8, 2020

I'm pretty sure I have already done this for 1.18

Update: yes, I have marked all the related classes as deprecated, however it was never mentioned in the changelog

@jaimeperez jaimeperez modified the milestones: 2.0, 1.19 Jan 8, 2020
@jaimeperez

This comment has been minimized.

Copy link
Member Author

@jaimeperez jaimeperez commented Jan 8, 2020

Yep, I saw it in the upgrade notes at least, but still wanted to add an issue as a reminder to check every place and maybe even add warnings in the logs.

@tvdijen

This comment has been minimized.

Copy link
Member

@tvdijen tvdijen commented Jan 8, 2020

I have done some preparations in this regard; 9c3913f
That's all I could find..

@jaimeperez

This comment has been minimized.

Copy link
Member Author

@jaimeperez jaimeperez commented Jan 8, 2020

Looks pretty exhaustive! But that's actually resolving #1268, not this one, right?

@tvdijen

This comment has been minimized.

Copy link
Member

@tvdijen tvdijen commented Jan 8, 2020

Correct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.