Skip to content

/ simplesamlphp

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the SimpleSAML_Auth_LDAP class #167

Closed
jaimeperez opened this issue Jan 15, 2015 · 3 comments
Closed

Move the SimpleSAML_Auth_LDAP class #167

jaimeperez opened this issue Jan 15, 2015 · 3 comments
Labels
enhancement low maintainability
Milestone
2.0

Comments

@jaimeperez
Copy link
Member

@jaimeperez jaimeperez commented Jan 15, 2015

This is actually more a collection of LDAP-related utilities, so move it to lib/SimpleSAML/Utils/LDAP.php. This of course needs refactoring everything using this class.
@jaimeperez jaimeperez added this to the v2.0 milestone Jan 15, 2015
@tvdijen tvdijen mentioned this issue Aug 4, 2017
Closed
@tvdijen
Copy link
Member

@tvdijen tvdijen commented Dec 11, 2018

Long time since the last comment, but this is still a relevant change for 2.0
@jaimeperez
Copy link
Member Author

@jaimeperez jaimeperez commented Dec 12, 2018

If it's not a huge amount of work, I'd favour doing this for 2.0.
@tvdijen
Copy link
Member

@tvdijen tvdijen commented May 17, 2019 •
edited

A little while back we've discussed this again on Whatsapp and decided the class could move to the ldap-module, which I did. The class now only is a wrapper, redirecting to the class in the module for BC-compatibility.
For 2.0 all we have left to do is to remove lib/SimpleSAML/Auth/LDAP.php from this repository.
@tvdijen tvdijen closed this in 2c8aa8a Feb 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement low maintainability
Projects
None yet
Milestone
2.0
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@tvdijen @jaimeperez