Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditional authproc filters #1693

Closed
dnmvisser opened this issue Sep 2, 2022 · 5 comments · Fixed by #1836
Closed

Conditional authproc filters #1693

dnmvisser opened this issue Sep 2, 2022 · 5 comments · Fixed by #1836

Comments

@dnmvisser
Copy link
Collaborator

I'm successfully using Second Factor Only (SFO) from https://github.com/OpenConextApps/simplesamlphp-module-stepupsfo. That is implemented by configuring a few authproc filters in sequence.
Configuring the authproc filter means that the second factor functionality is enabled for everyone.
It would be good if authproc filter(s) could be made conditional, for instance on the presence/absence of specific attributes.
This would allow a phased approach, for example only apply SFO to users that are part of a specific group in our directory.
Once this is running without problem, require more groups, and eventually to everyone.

@tvdijen
Copy link
Member

tvdijen commented Sep 15, 2022

You said on whatsapp that you went with Cirrus' implementation of the conditional authproc-filter.. I think it would make sense to import that one into SimpleSAMLphp

@tvdijen tvdijen added this to To do in 2.1 release via automation Sep 21, 2022
@tvdijen tvdijen added this to the 2.1 milestone Sep 21, 2022
@tvdijen
Copy link
Member

tvdijen commented Mar 21, 2023

@pradtke Would it be okay if we imported your 'PhpConditionalAuthProcInserter', 'BaseConditionalAuthProcInserter' and 'AuthProcRuleInserter'?

@pradtke
Copy link
Contributor

pradtke commented Mar 22, 2023

@tvdijen Yes, please go ahead. Plan sounds good. I started updating the module for sspv2, so take a look at that branch https://github.com/cirrusidentity/simplesamlphp-module-cirrusgeneral/tree/sspv2 for a better version to import.

@thijskh
Copy link
Member

thijskh commented Aug 2, 2023

Would definitely be useful to have in SimpleSAMLphp core

@tvdijen
Copy link
Member

tvdijen commented Aug 2, 2023

I kinda forgot about this, but we can still import it and add it to 2.1

2.1 release automation moved this from To do to Done Sep 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Development

Successfully merging a pull request may close this issue.

4 participants