Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "userid.attribute" #3

Open
olavmrk opened this issue Feb 27, 2014 · 6 comments
Open

Remove "userid.attribute" #3

olavmrk opened this issue Feb 27, 2014 · 6 comments
Milestone

Comments

@olavmrk
Copy link
Contributor

@olavmrk olavmrk commented Feb 27, 2014

This option can be set on destination and source metadata, but relying on this attribute makes filters rather confusing. It would be better to specifically list the attribute to be used as an user identifier in the applicable filters.

@gollmann
Copy link
Contributor

@gollmann gollmann commented Mar 22, 2016

Hi,
there seems to be an inconsistency in SSP 1.14 regarding userid.attribute:

Setting the attribute for the IdP in saml20-idp-hosted.php already results in warnings:

The 'userid.attribute' option has been deprecated.

OTOH the consent module (consent:Consent) still requires the UserID, see https://simplesamlphp.org/docs/stable/consent:consent

NB: since the consent module is run after attributes are filtered the uid-attribute usually is not and should not be available anymore.

Kind regards, Georg

@jaimeperez
Copy link
Member

@jaimeperez jaimeperez commented Mar 22, 2016

Hi @gollmann!

The userid.attribute option has been indeed deprecated, and will be removed in 2.0. That doesn't mean it's no longer in use. It is, in many places, and we'll slowly take it off. It will keep working during 1.14.x as you have seen, and also in 1.15.x, but in the latter there will be alternatives to it for every module or place where it's used.

MarvinDurot added a commit to Elipce-Informatique/simplesamlphp that referenced this issue Jun 29, 2016
MarvinDurot added a commit to Elipce-Informatique/simplesamlphp that referenced this issue Jun 29, 2016
falco76 pushed a commit to falco76/simplesamlphp that referenced this issue Apr 19, 2018
Corretta la guida alla config con i path corretti.
@w3care

This comment was marked as off-topic.

@jaimeperez

This comment was marked as off-topic.

@thijskh
Copy link
Member

@thijskh thijskh commented Aug 29, 2018

@jaimeperez I'm not sure it's useful to start issuing deprecation notices to users if they cannot stop using that configuration setting. Maybe we should just mark it as deprecated in the code?

When the time has come that you indeed do not need to use this option anymore, we'd need to put something in the upgrade notes to tell users what the alternatives are, because that's now also lacking.

tvdijen added a commit that referenced this issue Jul 23, 2019
tvdijen added a commit that referenced this issue Aug 10, 2019
tvdijen added a commit that referenced this issue Aug 31, 2019
Merge with project
tvdijen added a commit that referenced this issue Aug 31, 2019
jaimeperez added a commit that referenced this issue Sep 24, 2019
Fix Psalm-issues batch #3
tvdijen added a commit that referenced this issue Sep 24, 2019
tvdijen added a commit that referenced this issue Sep 28, 2019
@tvdijen
Copy link
Member

@tvdijen tvdijen commented Aug 6, 2020

The consent-module was taken care of. We picked 'identifyingAttribute' as a config setting

tvdijen added a commit that referenced this issue Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants