New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSR-2 compliant whitespace #458

Closed
hmpf opened this Issue Sep 5, 2016 · 2 comments

Comments

Projects
None yet
4 participants
@hmpf
Contributor

hmpf commented Sep 5, 2016

Fix whitespace as per PSR-2.

When fixing whitespace, ONLY do that for that commit, as this makes git blame -w work better.
Reference this issue in the commit message, for instance in the body as "For: #458". Don't do too many files in one go, only one module per commit for instance.

If fixing whitespace in a template leads to it rendering differently, the template is bugged. Take screenshots of before and after, add them to a new issue referencing this one, and also mention what browser you are using.

@hmpf hmpf added this to the 1.15.0 milestone Sep 5, 2016

precurse added a commit to precurse/simplesamlphp that referenced this issue Nov 10, 2016

thijskh added a commit that referenced this issue Nov 14, 2016

Code style: spaces, lowercase keywords.
No functional changes.

For: #458

@jaimeperez jaimeperez added the started label Jul 19, 2017

@jaimeperez jaimeperez modified the milestones: v1.16, 1.15.0 Aug 3, 2017

tvdijen added a commit to tvdijen/simplesamlphp that referenced this issue Aug 7, 2017

tvdijen added a commit to tvdijen/simplesamlphp that referenced this issue Aug 7, 2017

tvdijen added a commit to tvdijen/simplesamlphp that referenced this issue Aug 7, 2017

mschwager added a commit to mschwager/simplesamlphp that referenced this issue Feb 27, 2018

@thijskh thijskh modified the milestones: 1.16, 2.0 May 28, 2018

@tvdijen tvdijen modified the milestones: 2.0, 1.17 Aug 22, 2018

@tvdijen tvdijen modified the milestones: 1.17, 1.18 Oct 11, 2018

@thijskh

This comment has been minimized.

Member

thijskh commented Oct 18, 2018

What is still missing here?

@tvdijen tvdijen modified the milestones: 1.18, 1.17 Oct 18, 2018

@tvdijen

This comment has been minimized.

Member

tvdijen commented Oct 18, 2018

Whitespace is done..
I've just ran phpcs and there are a handful of other PSR-2 issues that I can address later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment