Skip to content

/ simplesamlphp

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up translations in consentAdmin #465

Closed
hmpf opened this issue Sep 6, 2016 · 2 comments
Closed

Clean up translations in consentAdmin #465

hmpf opened this issue Sep 6, 2016 · 2 comments
Projects
New internationalization system
Milestone
2.0

Comments

@hmpf
Copy link
Contributor

@hmpf hmpf commented Sep 6, 2016

For #455. This will also fix #464.
@hmpf hmpf added this to the 1.15.0 milestone Sep 6, 2016
hmpf added a commit that referenced this issue Oct 28, 2016
@hmpf
Move context-changing function out of template
Loading status checks…
239db7b 
For #454 and #465
hmpf added a commit that referenced this issue Oct 28, 2016
@hmpf
Namespace translation tags
Loading status checks…
235b6d8 
Note the tags 'spname' and spdescription' that cannot be namespaced because
their translations are loaded dynamically.

For #455 and #465
@jaimeperez jaimeperez modified the milestones: v1.16, 1.15.0 Aug 3, 2017
tvdijen added a commit to tvdijen/simplesamlphp that referenced this issue Aug 7, 2017
@hmpf @tvdijen
Move context-changing function out of template
53d07c8 
For simplesamlphp#454 and simplesamlphp#465
tvdijen added a commit to tvdijen/simplesamlphp that referenced this issue Aug 7, 2017
@hmpf @tvdijen
Namespace translation tags
3e9a5de 
Note the tags 'spname' and spdescription' that cannot be namespaced because
their translations are loaded dynamically.

For simplesamlphp#455 and simplesamlphp#465
@thijskh thijskh modified the milestones: 1.16, 1.17 May 27, 2018
@tvdijen tvdijen modified the milestones: 1.17, 1.18 Oct 11, 2018
This was referenced Nov 20, 2018
Closed
Closed
@thijskh
Copy link
Member

@thijskh thijskh commented Nov 20, 2018

Remove calls to old translation system:

  • Translate->getTag()
  • Translate->includeLanguageFile()
  • Translate->includeInlineTranslation()
  • Translate->getAttributeTranslation()
@thijskh thijskh modified the milestones: 1.18, 2.0 Nov 20, 2018
@tvdijen
Copy link
Member

@tvdijen tvdijen commented Mar 14, 2019

simplesamlphp/simplesamlphp-module-consentadmin#1
@tvdijen tvdijen closed this Mar 14, 2019
@tvdijen tvdijen moved this from Backlog to Done in New internationalization system Jul 12, 2019
@ghalse ghalse mentioned this issue Aug 13, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
New internationalization system
Done
Milestone
2.0
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
@tvdijen @jaimeperez @thijskh @hmpf