New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre migrate templates: move logic to calling page #485

Closed
hmpf opened this Issue Oct 4, 2016 · 0 comments

Comments

4 participants
@hmpf
Contributor

hmpf commented Oct 4, 2016

Sometimes, elaborate logic or a function in the template is there to select something from data in the context. Move this to the calling page and dump the result in the context.

These cannot be found with a quick grep through the code, but an if or a loop that only uses what's in the context to set something only used in the template is the giveaway.

@hmpf hmpf added this to the 1.15.0 milestone Oct 4, 2016

hmpf added a commit that referenced this issue Oct 4, 2016

@jaimeperez jaimeperez modified the milestones: v1.16, 1.15.0 Aug 3, 2017

tvdijen added a commit to tvdijen/simplesamlphp that referenced this issue Aug 7, 2017

@thijskh thijskh modified the milestones: 1.16, 1.17 May 27, 2018

@tvdijen tvdijen modified the milestones: 1.17, 1.18 Oct 11, 2018

@thijskh thijskh modified the milestones: 1.18, 1.17 Nov 20, 2018

@thijskh thijskh closed this Nov 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment