Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontpage_federation does not display expired entities #747

Open
tvdijen opened this Issue Dec 12, 2017 · 5 comments

Comments

Projects
None yet
3 participants
@tvdijen
Copy link
Member

tvdijen commented Dec 12, 2017

This page has logic in place to display and mark expired metadata entities on the frontpage_federation-page, but it appears that this never happens. Actually, expired metadata entities are completely hidden from the view.

A little investigation turned out that MetaDataStorageHandler::getList() filters out any entity that has expired and there really isn't an alternative to get the full unfiltered list of configured entities.

We either need a method to fetch unfiltered entities, or stop filtering them in getList and move that logic to wherever it may be desirable to filter them.

@thijskh thijskh changed the title Bug in frontpage_federation page Frontpage_federation does not display expired entities Nov 19, 2018

@thijskh

This comment has been minimized.

Copy link
Member

thijskh commented Nov 21, 2018

Is a duplicate of #183?

@tvdijen

This comment has been minimized.

Copy link
Member Author

tvdijen commented Dec 11, 2018

It seems so yes.. That one doesn't clearly seem to explain the issue though... Feel free to close either one, as long as it's clear that we need to be able to pull metadata even if it's expired, then I'm fine!

@jaimeperez

This comment has been minimized.

Copy link
Member

jaimeperez commented Dec 12, 2018

This is tricky because if we just remove the filter, it could cause that expired entities are now usable. I haven't looked into the code, but I would try to keep the behaviour as it is now, and either add an optional parameter to getList() to signal that we don't want it to filter entities, or add a completely new method.

@tvdijen

This comment has been minimized.

Copy link
Member Author

tvdijen commented Dec 12, 2018

I think I would add a new method with a callback parameter, so that different kinds of filters can be used dynamically (or null for unfiltered).. Then we can at least fix the federation page to show expired entries

@tvdijen tvdijen added this to the 1.18 milestone Mar 14, 2019

@tvdijen

This comment has been minimized.

Copy link
Member Author

tvdijen commented Mar 14, 2019

I consider this an issue for the new admin module and therefore tagged it for 1.18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.