New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newUI: translation issues #948

Open
tvdijen opened this Issue Oct 5, 2018 · 5 comments

Comments

3 participants
@tvdijen
Member

tvdijen commented Oct 5, 2018

This issue is probably bigger than the two mentions above...

@tvdijen tvdijen added the help wanted label Oct 5, 2018

@tvdijen tvdijen modified the milestones: 1.17, 1.18 Oct 5, 2018

@thijskh thijskh modified the milestones: 1.18, 1.17 Nov 20, 2018

@tvdijen

This comment has been minimized.

Member

tvdijen commented Nov 28, 2018

I remember us talking about this in Valencia, but was this fixed eventually? @thijskh @jaimeperez

@jaimeperez

This comment has been minimized.

Member

jaimeperez commented Nov 29, 2018

I haven't really worked on this, not even tested. If, by any chance, it is already fixed, that was accidental 😄

@tvdijen

This comment has been minimized.

Member

tvdijen commented Dec 7, 2018

I can confirm this is still an issue..

I did a test with the 'Metadata not found' and debug logging shows that the 'core' translation domain is not loaded.. Just the root 'messages' domain is available on the error page.

@tvdijen

This comment has been minimized.

Member

tvdijen commented Dec 7, 2018

The error-template is just not aware of the calling template... And we were so close!

private $module = null;

That property is never used/set, but if set it would be used to add the proper translation domain, solving this issue instantly!

@tvdijen tvdijen modified the milestones: 1.17, 1.18 Dec 7, 2018

@tvdijen

This comment has been minimized.

Member

tvdijen commented Dec 7, 2018

Marked for 1.17 milestone since old UI is working perfectly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment