New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs on theme.controller setting #1026

Merged
merged 4 commits into from Dec 24, 2018

Conversation

2 participants
@tvdijen
Copy link
Member

tvdijen commented Dec 23, 2018

Closes #946

tvdijen added some commits Dec 23, 2018

@tvdijen tvdijen added the docs label Dec 23, 2018

@tvdijen tvdijen added this to the 1.18 milestone Dec 23, 2018

@tvdijen

This comment has been minimized.

Copy link
Member

tvdijen commented Dec 23, 2018

@jaimeperez it's a start, so if you have any additions?

@jaimeperez
Copy link
Member

jaimeperez left a comment

It's a good start, I would say! Thanks a lot for taking the time to document this, Tim! It might be a good idea to mention the two entry points in the interface and explain what they are used for, but on the other hand that's already documented in the interface itself...

Show resolved Hide resolved docs/simplesamlphp-theming.md Outdated

@tvdijen tvdijen merged commit b6de826 into master Dec 24, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@tvdijen tvdijen deleted the tvdijen-theme-controller branch Dec 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment