New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Psalm issues lib/ #1045

Open
wants to merge 18 commits into
base: master
from

Conversation

Projects
None yet
1 participant
@tvdijen
Copy link
Member

tvdijen commented Feb 3, 2019

I ran a check with the latest version of Psalm, which kinda opened Pandora's box on me..
This PR attempts to fix as much of the low-hanging fruit as possible for files in the lib-directory.

Still a very very long way to go though :(

620 errors found
916 other issues found

I will do another PR for the modules

tvdijen added some commits Feb 2, 2019

Fixes for the remainder of lib/SimpleSAML/XML
Fixes for the remainder of lib/SimpleSAML

@tvdijen tvdijen added this to the 1.18 milestone Feb 3, 2019

@tvdijen tvdijen changed the title Fix Psalm issues Fix Psalm issues lib/ Feb 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment