Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rememberme: Set cookie lifetime iso expire fixing the remember me fea… #1088

Conversation

Projects
None yet
2 participants
@fingerspitziluijks
Copy link

fingerspitziluijks commented Apr 1, 2019

rememberme: Set cookie lifetime iso expire fixing the remember me feature and respective errors.

Currently the remember me functionality does not work correctly and using it results in severable undefined index errors as the expire cookie parameter is passed along the SessionHandlerPHP which does not accept this one. Using lifetime instead of expire, effectively doing the same thing, this can be fixed in a pretty simple way. Next to that the params given to the session handler are merged with the current ones before given to the session handler instead of after.

rememberme: Set cookie lifetime iso expire fixing the remember me fea…
…ture and respective errors.

Currently the remember me functionality does not work correctly and using it results in severable undefined index errors as the expire cookie parameter is passed along the SessionHandlerPHP which does not accept this one. Using lifetime instead of expire, effectively doing the same thing, this can be fixed in a pretty simple way. Next to that the params given to the session handler are merged with the current ones before given to the session handler instead of after.
@tvdijen

tvdijen approved these changes Apr 1, 2019

Copy link
Member

tvdijen left a comment

Good catch!

@tvdijen tvdijen added this to the 2.0 milestone Apr 1, 2019

@tvdijen

This comment has been minimized.

Copy link
Member

tvdijen commented Apr 1, 2019

Since this will break the API, it will have to wait until 2.0.. Until then we can fix the description in config.php

@fingerspitziluijks

This comment has been minimized.

Copy link
Author

fingerspitziluijks commented Apr 3, 2019

Thanks and excellent, love to see this feature working (again)!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.