Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Add support for "rewritten urls" in module detection #1095
The code adds a new method to get module information from url.
The last commit is now supporting urls without trailiing slash (/register)
referenced this pull request
Apr 10, 2019
tvdijen left a comment
I hope you don't mind, but I took care of some coding style..
Besides that, this is a neat PR!
Hi @dweeves !
I've asked Jaime again to take a look at this PR. I know there are several version of 'routing improvement' lying around and we need to pick a strategy here. A finalized version of the routing-feature will be part of a v1.18-release, hopefully somewhere in Q4 this year depending on resources.
jaimeperez left a comment
Thanks a lot for your contribution, @dweeves!
If I understand the issue correctly, it actually lies in Symfony, and this is just a workaround. Shouldn't we try to get this fixed upstream?
Essentially, introducing an abstraction layer (offloading request parsing to Symfony, instead of using
Note though that I'm just thinking out loud here