Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Webmozart assertions #1132
This means that the wishes from the administrator by means of
If assertions must be done using a library instead of calling the
This is about using a string as the assertion, where PHP has to run
The webmozart project uses __callStatic, which breaks static code analyses, making mistakes like ba0b826 go unnoticed. At the same time its yet another dependency to replace a one-liner with another one-liner. I already mentioned respecting the administrators wishes with regard to php.ini settings for assertions.
At the end of the day, this is a bikeshed issue, so if this has already been decided, I won't stand in the way. However I do want to point out that the original reasoning for this change (deprecation) has been based on a misunderstanding. The current way SimpleSAMLphp does things is not currently, or about to be, deprecated.
OK, bikeshed it is! 4pm after detention class
@edit: I've discussed this offline with Jaime again and basically we don't care about administrators.. If it triggers and exception, it's a bug and it should be fixed.