Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor routing #1178

Merged
merged 20 commits into from Dec 31, 2019
Merged

Refactor routing #1178

merged 20 commits into from Dec 31, 2019

Conversation

@tvdijen
Copy link
Member

@tvdijen tvdijen commented Aug 3, 2019

Based on https://github.com/sgomez/simplesamlphp#refactor-routing

@tvdijen tvdijen changed the title Refactor routing WIP: Refactor routing Aug 3, 2019
@tvdijen

This comment has been hidden.

@tvdijen tvdijen added this to the 1.18 milestone Aug 3, 2019
lib/SimpleSAML/Kernel.php Show resolved Hide resolved
Loading
@tvdijen tvdijen force-pushed the refactor-routing-rebased branch 3 times, most recently from 250797d to 6594d55 Aug 5, 2019
@tvdijen tvdijen changed the title WIP: Refactor routing Refactor routing Aug 5, 2019
@tvdijen tvdijen requested a review from jaimeperez Aug 5, 2019
Copy link
Member Author

@tvdijen tvdijen left a comment

A few comments I have myself on this code:

  • I'm not sure cache should go into the tempdir, but we don't really have a cache-dir unless we use the same cache-dir we use for Twig-templates.. In that case, we need a default/fallback in case it is not set.
  • We need to update the release-procedure to update the constants in the Kernel-class.. Can we improve this so we have less settings to update on a new release?
  • I'm not happy with the location of the configuration files.. I feel they shouldn't go inside the lib/ directory, but somewhere in the root-directory
  • One thing I've noticed is that things break if the log/cache-dirs are not writeable by Apache/PHP.. I don't log to files, but directly to syslog, so it shouldn't necessarily break. This may not be avoidable because it's Symfony that chokes..

Loading

lib/SimpleSAML/Kernel.php Outdated Show resolved Hide resolved
Loading
@tvdijen tvdijen force-pushed the refactor-routing-rebased branch 4 times, most recently from 6e85845 to a3dc852 Aug 8, 2019
@tvdijen tvdijen force-pushed the refactor-routing-rebased branch 3 times, most recently from 2d4a270 to 8540474 Aug 9, 2019
@tvdijen

This comment has been hidden.

@tvdijen tvdijen force-pushed the refactor-routing-rebased branch 7 times, most recently from df51aea to 5d81359 Aug 9, 2019
@tvdijen tvdijen force-pushed the refactor-routing-rebased branch 3 times, most recently from 9bb31f7 to ae297a9 Nov 22, 2019
@tvdijen
Copy link
Member Author

@tvdijen tvdijen commented Nov 22, 2019

Part of this PR has been merged, hopefully making the remainder easier to review..

Loading

@tvdijen tvdijen force-pushed the refactor-routing-rebased branch 2 times, most recently from 0f2ebb2 to 5ab8409 Nov 24, 2019
@tvdijen tvdijen force-pushed the refactor-routing-rebased branch from e15c41d to e9f6920 Dec 24, 2019
@tvdijen tvdijen force-pushed the refactor-routing-rebased branch from 7e39bb0 to 0a48e2c Dec 24, 2019
@tvdijen tvdijen merged commit 54a6d7d into master Dec 31, 2019
5 of 7 checks passed
Loading
@tvdijen tvdijen deleted the refactor-routing-rebased branch Dec 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants