Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add controller for the cron-module #1181

Merged
merged 7 commits into from Oct 14, 2019
Merged

Add controller for the cron-module #1181

merged 7 commits into from Oct 14, 2019

Conversation

@tvdijen
Copy link
Member

@tvdijen tvdijen commented Aug 10, 2019

This depends on #1178

@tvdijen tvdijen added this to the 1.18 milestone Aug 26, 2019
@tvdijen tvdijen removed this from the 1.18 milestone Aug 29, 2019
@tvdijen tvdijen added this to the 1.19 milestone Aug 29, 2019
@tvdijen
Copy link
Member Author

@tvdijen tvdijen commented Sep 25, 2019

I think this is done now, but I'd rather not approve my own PR's, especially because I don't use the module myself, so feedback would be appreciated!

Loading

@tvdijen tvdijen force-pushed the routing-cron branch 2 times, most recently from 73284cf to b312093 Sep 26, 2019
@tvdijen tvdijen requested a review from jaimeperez Sep 26, 2019
@codecov
Copy link

@codecov codecov bot commented Oct 11, 2019

Codecov Report

Merging #1181 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1181   +/-   ##
=========================================
  Coverage     36.33%   36.33%           
  Complexity     3744     3744           
=========================================
  Files           136      136           
  Lines         11434    11434           
=========================================
  Hits           4154     4154           
  Misses         7280     7280

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 416234b...519bbad. Read the comment docs.

Loading

@tvdijen tvdijen merged commit ef273bd into master Oct 14, 2019
7 checks passed
Loading
@tvdijen tvdijen deleted the routing-cron branch Oct 14, 2019
tvdijen added a commit that referenced this issue Nov 9, 2019
tvdijen added a commit that referenced this issue Nov 9, 2019
tvdijen added a commit that referenced this issue Nov 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant