Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rationalize SQL Store insertOrUpdate #1193

Merged
merged 3 commits into from Aug 31, 2019

Conversation

@tvdijen
Copy link
Member

commented Aug 30, 2019

Closes #423

Needs testing by someone using any DBMS other than mysql & sqllite
We can actually test this on any DBMS as the default case should always work.. It works fine after resolving a little mistake

@tvdijen tvdijen added this to the 1.18 milestone Aug 30, 2019

tvdijen added 2 commits Aug 31, 2019

@tvdijen tvdijen merged commit 236a4e4 into master Aug 31, 2019

5 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.01%) to 35.091%
Details

@tvdijen tvdijen deleted the simplesamlphp-rationalize-sqlstore branch Aug 31, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.