Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise PHP functional level to 7.2 #1201

Merged
merged 8 commits into from Feb 14, 2020
Merged

Raise PHP functional level to 7.2 #1201

merged 8 commits into from Feb 14, 2020

Conversation

@tvdijen
Copy link
Member

@tvdijen tvdijen commented Sep 12, 2019

No description provided.

@tvdijen tvdijen added this to the 2.0 milestone Sep 12, 2019
@tvdijen tvdijen added this to In progress in 2.0 release via automation Sep 12, 2019
@codecov
Copy link

@codecov codecov bot commented Oct 14, 2019

Codecov Report

Merging #1201 into master will decrease coverage by 0.35%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1201      +/-   ##
============================================
- Coverage     36.84%   36.48%   -0.36%     
+ Complexity     3777     3767      -10     
============================================
  Files           138      137       -1     
  Lines         11451    11417      -34     
============================================
- Hits           4219     4166      -53     
- Misses         7232     7251      +19
Impacted Files Coverage Δ Complexity Δ
lib/SimpleSAML/Utils/EMail.php 0% <0%> (-59.1%) 30% <0%> (-2%)
modules/core/lib/Controller/Login.php 74.24% <0%> (-0.76%) 18% <0%> (ø)
lib/SimpleSAML/Utils/XML.php 63.52% <0%> (ø) 74% <0%> (ø) ⬇️
lib/SimpleSAML/Metadata/Signer.php 0% <0%> (ø) 32% <0%> (ø) ⬇️
modules/core/lib/Controller/Exception.php 0% <0%> (ø) 9% <0%> (-1%) ⬇️
lib/SimpleSAML/Kernel.php
lib/SimpleSAML/Command/RouterDebugCommand.php
lib/SimpleSAML/Console/Application.php
lib/SimpleSAML/HTTP/Router.php 0% <0%> (ø) 9% <0%> (?)
lib/SimpleSAML/Module/ControllerResolver.php 0% <0%> (ø) 13% <0%> (?)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1e3604...fa5a96b. Read the comment docs.

@tvdijen tvdijen changed the title Upgrade to PHP 7.2 Raise PHP functional level to 7.2 Nov 28, 2019
@tvdijen tvdijen merged commit f67a07c into master Feb 14, 2020
0 of 5 checks passed
2.0 release automation moved this from In progress to Done Feb 14, 2020
@tvdijen tvdijen deleted the php72 branch Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
2.0 release
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant