Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twig Strict vars #1264

Merged
merged 4 commits into from Dec 31, 2019
Merged

Twig Strict vars #1264

merged 4 commits into from Dec 31, 2019

Conversation

@tvdijen
Copy link
Member

tvdijen commented Dec 24, 2019

Enable twig strict vars and fix broken templates

@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 24, 2019

Codecov Report

Merging #1264 into master will increase coverage by 0.81%.
The diff coverage is 25%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1264      +/-   ##
============================================
+ Coverage     36.48%   37.29%   +0.81%     
- Complexity     3767     4382     +615     
============================================
  Files           137      137              
  Lines         11417    17022    +5605     
============================================
+ Hits           4165     6349    +2184     
- Misses         7252    10673    +3421
Impacted Files Coverage Δ Complexity Δ
lib/SimpleSAML/Locale/Translate.php 19.92% <0%> (+0.51%) 72 <0> (+11) ⬆️
lib/SimpleSAML/XHTML/Template.php 32.82% <28.57%> (+0.8%) 102 <0> (+9) ⬆️
lib/SimpleSAML/Error/ErrorCodes.php 88.23% <0%> (-4.63%) 12% <0%> (+4%)
lib/SimpleSAML/Stats.php 51.16% <0%> (-2.41%) 7% <0%> (ø)
lib/SimpleSAML/Store/Redis.php 88.33% <0%> (-1.92%) 15% <0%> (ø)
lib/SimpleSAML/SessionHandler.php 92.59% <0%> (-1.53%) 7% <0%> (+1%)
modules/core/lib/Controller/Login.php 72.81% <0%> (-1.43%) 31% <0%> (+13%)
...leSAML/Metadata/MetaDataStorageHandlerFlatFile.php 91.3% <0%> (-1.29%) 10% <0%> (ø)
modules/saml/lib/IdP/SQLNameID.php 86.66% <0%> (-1.22%) 24% <0%> (ø)
modules/core/lib/Auth/Process/TargetedID.php 37.03% <0%> (-1.15%) 17% <0%> (ø)
... and 129 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd71fcd...cfb6cb6. Read the comment docs.

@tvdijen tvdijen added this to the 1.19 milestone Dec 24, 2019
@tvdijen tvdijen added the enhancement label Dec 24, 2019
@tvdijen tvdijen merged commit 09f4ee1 into master Dec 31, 2019
6 of 7 checks passed
6 of 7 checks passed
codecov/patch 25% of diff hit (target 36.48%)
Details
Scrutinizer Analysis: 14 new issues – Tests: passed
Details
codecov/project 37.29% (+0.81%) compared to bd71fcd
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@tvdijen tvdijen deleted the twig-strictvars branch Dec 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.