Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistently treat scopes with multiple @ #514

Merged
merged 1 commit into from Aug 26, 2020

Conversation

@thijskh
Copy link
Member

@thijskh thijskh commented Nov 14, 2016

See discussion in #236.

@thijskh thijskh added this to the v2.0 milestone Nov 14, 2016
@tvdijen tvdijen force-pushed the feature/consistently-treat-scopes-with-multiple-at branch from 533cb65 to 8a1fc98 Dec 8, 2018
@tvdijen tvdijen force-pushed the feature/consistently-treat-scopes-with-multiple-at branch from e6ddb44 to 3dceb88 Aug 31, 2019
@tvdijen
Copy link
Member

@tvdijen tvdijen commented Aug 31, 2019

31/08/2019: rebased against master

@tvdijen tvdijen added this to In progress in 2.0 release via automation Nov 22, 2019
@tvdijen tvdijen force-pushed the master branch 3 times, most recently from 1c686ab to eb20457 Aug 17, 2020
eduPerson recommends: 'Multiple "@" signs are not recommended, but in any case,
the first occurrence of the "@" sign starting from the left is to be taken as
the delimiter between components. Thus, user identifier is to the left,
security domain to the right of the first "@".'

Closes #236
@thijskh thijskh force-pushed the feature/consistently-treat-scopes-with-multiple-at branch from bb51416 to 4dc77c9 Aug 26, 2020
@codecov
Copy link

@codecov codecov bot commented Aug 26, 2020

Codecov Report

Merging #514 into master will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master     #514   +/-   ##
=========================================
  Coverage     44.50%   44.50%           
  Complexity     3445     3445           
=========================================
  Files           139      139           
  Lines         10316    10316           
=========================================
  Hits           4591     4591           
  Misses         5725     5725           
@thijskh thijskh merged commit 499c6d7 into master Aug 26, 2020
6 checks passed
6 checks passed
Scrutinizer Analysis: 2 new issues – Tests: passed
Details
codecov/project 44.50% (+0.00%) compared to c1029a0
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
2.0 release automation moved this from In progress to Done Aug 26, 2020
@thijskh thijskh deleted the feature/consistently-treat-scopes-with-multiple-at branch Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2.0 release
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants