New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement "Remember my Organization" in multiple-ldap #704

Closed
wants to merge 5 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@aguvillalba
Contributor

aguvillalba commented Oct 16, 2017

This new feature allows the users to have a checkbox in the login form
which works in the same way than "Remember my username" but for the
organization selected in the dropdown
Implements feature requested in issue: Allow "Remember organization" for multiple-ldap authsource #703

aguvillalba added some commits Oct 16, 2017

Implement "Remember my Organization" in multiple-ldap
This new feature allows the users to have a checkbox in the login form
which works in the same way than "Remember my username" but for the
organization selected in the dropdown
Implement "Remember my Organization" in multiple-ldap
This new feature allows the users to have a checkbox in the login form
which works in the same way than "Remember my username" but for the
organization selected in the dropdown
Implement "Remember my Organization" in multiple-ldap
This new feature allows the users to have a checkbox in the login form
which works in the same way than "Remember my username" but for the
organization selected in the dropdown

@thijskh thijskh added this to the 1.16 milestone Oct 16, 2017

// Give the user an option to save their organization choice for future login
// attempts. And when enabled, what should the default be, checked or not.
//'remember.organization.enabled' => false,
//'remember.organization.checked' => false,

This comment has been minimized.

@tvdijen

tvdijen Jan 8, 2018

Member

Your white-spaces are off here

* Getter for the authsource config option remember.organization.enabled
* @return bool
*/
public function getRememberOrganizationEnabled() {

This comment has been minimized.

@tvdijen

tvdijen Jan 8, 2018

Member

Following PSR-2 code guidelines, the { should go on the next line

* Getter for the authsource config option remember.organization.checked
* @return bool
*/
public function getRememberOrganizationChecked() {

This comment has been minimized.

@tvdijen

tvdijen Jan 8, 2018

Member

Same here

@tvdijen

This comment has been minimized.

Member

tvdijen commented Jan 8, 2018

@thijskh How about we merge this into the Xnew-ui branch?

@tvdijen tvdijen added the enhancement label Jan 8, 2018

@jaimeperez

This comment has been minimized.

Member

jaimeperez commented Jan 8, 2018

I agree, I think it makes sense to add this functionality directly to the new user interface.

@aguvillalba do you think you would be able to migrate this PR to the Xnew-ui branch and implement it directly into the twig templates?

@tvdijen

tvdijen approved these changes Jan 8, 2018

@aguvillalba

This comment has been minimized.

Contributor

aguvillalba commented Jan 8, 2018

Solved the PSR-2 mentioned issues.
Regarding to migrate to Xnew-ui, ok! I can try it, but I am not sure when it can be finished (busy with other stuff). I will definitely try.

@jaimeperez

This comment has been minimized.

Member

jaimeperez commented Jan 8, 2018

¡Gracias Agustín! 😉

@tvdijen tvdijen referenced this pull request Feb 14, 2018

Merged

new user interface #717

@tvdijen

This comment has been minimized.

Member

tvdijen commented May 11, 2018

I have put a little effort in the Twig-template and then merged this into the Xnew-ui branch

@tvdijen tvdijen closed this May 11, 2018

@aguvillalba

This comment has been minimized.

Contributor

aguvillalba commented Sep 20, 2018

@tvdijen @jaimeperez was this pull request finally merged into version 1.16? I am not sure...

@thijskh thijskh modified the milestones: 1.16, 1.17 Sep 20, 2018

@thijskh

This comment has been minimized.

Member

thijskh commented Sep 20, 2018

Afraid not, this will be in 1.17. Updated milestone.

@tvdijen

This comment has been minimized.

Member

tvdijen commented Sep 20, 2018

It only exists in master right now

@aguvillalba

This comment has been minimized.

Contributor

aguvillalba commented Sep 20, 2018

So, what should I do then?

@thijskh

This comment has been minimized.

Member

thijskh commented Sep 20, 2018

Wait until 1.17 is released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment