New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespace remaining non-namespaced classes #869

Merged
merged 14 commits into from Jun 5, 2018

Conversation

Projects
None yet
2 participants
@tvdijen
Member

tvdijen commented May 29, 2018

No description provided.

@tvdijen tvdijen added this to the 1.17 milestone May 29, 2018

@tvdijen tvdijen force-pushed the tvdijen:patch-namespace branch 4 times, most recently from e94993e to b8fb4dc May 29, 2018

@jaimeperez jaimeperez added the started label May 30, 2018

@tvdijen tvdijen force-pushed the tvdijen:patch-namespace branch 15 times, most recently from b23e2a6 to 745678f May 30, 2018

@tvdijen tvdijen force-pushed the tvdijen:patch-namespace branch from b7da7a7 to 116c706 May 31, 2018

@tvdijen tvdijen removed the started label May 31, 2018

@tvdijen tvdijen force-pushed the tvdijen:patch-namespace branch 5 times, most recently from 9afbd03 to cc2967b May 31, 2018

@jaimeperez

Tim, the SimpleSAML_Utilities class has been deprecated for a long time now, so all references to it should be changed to refer to their counterparts in the Utils directory.

@tvdijen

This comment has been minimized.

Member

tvdijen commented Jun 1, 2018

Will do! Do you want me to remove the class completely since it's been deprecated for so long already? Or just get rid of the references..

@jaimeperez

This comment has been minimized.

Member

jaimeperez commented Jun 1, 2018

No, let's keep it for now, as it is marked for removal in 2.0...

@tvdijen tvdijen force-pushed the tvdijen:patch-namespace branch 2 times, most recently from 1c9fffd to 25f5a54 Jun 1, 2018

@tvdijen tvdijen changed the title from WIP: namespace remaining non-namespaced classes to Namespace remaining non-namespaced classes Jun 1, 2018

@tvdijen tvdijen force-pushed the tvdijen:patch-namespace branch from 25f5a54 to 9b7361e Jun 1, 2018

@tvdijen

This comment has been minimized.

Member

tvdijen commented Jun 1, 2018

If anyone could run a few tests with this branch that would be wonderful..

Only remaining references are in changelog / upgrade notes..

@tvdijen tvdijen merged commit 81d7182 into simplesamlphp:master Jun 5, 2018

1 of 2 checks passed

coverage/coveralls Coverage decreased (-0.09%) to 30.468%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@tvdijen tvdijen deleted the tvdijen:patch-namespace branch Jul 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment