New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converted array declarations #959

Merged
merged 8 commits into from Oct 17, 2018

Conversation

Projects
None yet
3 participants
@ArnoVanDerVegt
Contributor

ArnoVanDerVegt commented Oct 9, 2018

Updated array declarations to the short version.

arno added some commits Oct 9, 2018

arno
arno
@thijskh

I see the benefit of this change, strongest for the config files which get a lot cleaner.

I'm missing updates in under docs/ I think. They should match the config templates we ship.

It touches a lot of files. Since the move to namespaces and psr-2 already changed a lot of files in 1.17, it may indeed be a good idea to bite this bullet aswell so we get as many of these sweeping changes out of the way in one release.

@tvdijen

This comment has been minimized.

Member

tvdijen commented Oct 9, 2018

This + namespaces might actually justify a 1.17 release with only non-functional changes

tvdijen and others added some commits Oct 10, 2018

@tvdijen tvdijen added this to the 1.17 milestone Oct 11, 2018

tvdijen added some commits Oct 13, 2018

@tvdijen tvdijen merged commit 3b4178d into simplesamlphp:master Oct 17, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 31.628%
Details

ghalse added a commit to safire-ac-za/safire-ac-za.github.io that referenced this pull request Oct 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment