Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type hints #969

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@tvdijen
Copy link
Member

tvdijen commented Oct 21, 2018

  • Added type hints wherever possible
  • Removed obselete calls to assert()
  • Added some phpdocs
  • Removed some tests that tested for invalid input (they make no sense anymore with the type hints)
  • Added a message to the upgrade notes > type hinting may affect 3rd party modules
@thijskh

This comment has been minimized.

Copy link
Member

thijskh commented Nov 21, 2018

Adding type hints on the Auth Source and Auth Processing Filters will break every Authsource or Authproc currently in use because the signatures will change, which are defined API's with been publishing for people to implement. So we should not do that without in a new major. I believe many of the "internal" functions already have type hints.

@tvdijen tvdijen added this to the 2.0 milestone Feb 13, 2019

@tvdijen tvdijen force-pushed the tvdijen:typehints branch 2 times, most recently from c178b0b to 02a14ba Feb 13, 2019

@tvdijen tvdijen force-pushed the tvdijen:typehints branch from 02a14ba to 1a36a37 Mar 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.