Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type hints #969

Closed
wants to merge 13 commits into from
Closed

Type hints #969

wants to merge 13 commits into from

Conversation

@tvdijen
Copy link
Member

@tvdijen tvdijen commented Oct 21, 2018

  • Added type hints wherever possible
  • Removed obselete calls to assert()
  • Added some phpdocs
  • Removed some tests that tested for invalid input (they make no sense any more with the type hints)
@thijskh
Copy link
Member

@thijskh thijskh commented Nov 21, 2018

Adding type hints on the Auth Source and Auth Processing Filters will break every Authsource or Authproc currently in use because the signatures will change, which are defined API's with been publishing for people to implement. So we should not do that without in a new major. I believe many of the "internal" functions already have type hints.

@tvdijen tvdijen added this to the 2.0 milestone Feb 13, 2019
@tvdijen tvdijen force-pushed the tvdijen:typehints branch 2 times, most recently from c178b0b to 02a14ba Feb 13, 2019
@tvdijen tvdijen force-pushed the tvdijen:typehints branch from 02a14ba to 1a36a37 Mar 5, 2019
@tvdijen tvdijen force-pushed the tvdijen:typehints branch from 1a36a37 to 38c6b74 May 16, 2019
@tvdijen tvdijen force-pushed the tvdijen:typehints branch 5 times, most recently from a7122c6 to dcf05c8 May 28, 2019
@tvdijen tvdijen force-pushed the tvdijen:typehints branch from 0ed1811 to cc4d2cb Jul 4, 2019
@tvdijen tvdijen force-pushed the tvdijen:typehints branch 2 times, most recently from b41e9a4 to e9a183b Jul 12, 2019
@tvdijen tvdijen force-pushed the tvdijen:typehints branch from e9a183b to ed91e1f Jul 23, 2019
@tvdijen tvdijen force-pushed the tvdijen:typehints branch from ed91e1f to 2060fdf Aug 10, 2019
@tvdijen tvdijen force-pushed the tvdijen:typehints branch from 2060fdf to d290394 Aug 18, 2019
@tvdijen
Copy link
Member Author

@tvdijen tvdijen commented Aug 18, 2019

Closing this, because it's not gonna get merged for 1.18..
For 2.0 I am preparing a new PR that will fully typehint the source, including scalars, return types, etc.

@tvdijen tvdijen closed this Aug 18, 2019
@tvdijen tvdijen deleted the tvdijen:typehints branch Aug 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants