New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate preprodwarning #994

Merged
merged 6 commits into from Nov 21, 2018

Conversation

Projects
None yet
2 participants
@dnmvisser
Contributor

dnmvisser commented Nov 21, 2018

The preprodwarning module has never been documented. Its purpose was to notify the user about the pre-production status of the instance, and require approval by clicking a button. However, because this logic was implemented as an authentication processing filter, both the notification and the approval button were shown after the user had successfully authenticated.
This doesn't make much sense.
This PR further discourages its use by removing the links to the (non-existing) documentation.
It still works, but it should be removed in 2.0.
Instead, the newly introduced production configuration flag is used to display a banner.
This does still need all the additional translations to be ported from preprodwarning

dnmvisser added some commits Nov 20, 2018

Add 'en' locale for non-production warning
All the old LC_MESSAGES content from the old
preprodwarning module will have to be added...
Add preproduction banner to legacy header template.
This uses the translations from the preprodwarning module,
and can be removed in 2.0 (together with legacy templates).

@thijskh thijskh merged commit b218028 into simplesamlphp:master Nov 21, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@thijskh thijskh added this to the 1.17 milestone Nov 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment