compatibility with symfony2.1 increased, unit tests working #35

Merged
merged 1 commit into from Sep 19, 2012

Conversation

Projects
None yet
5 participants
@wwwdata
Contributor

wwwdata commented Sep 12, 2012

bootstrap file was outdated and I fixed as much as I needed to
run the bundle again. There is still a lot of deprecated functions that
need to be fixed, but that is some work and requires time I did not have
atm...

I fixed as much CS as I could, generally this bundle does not conform to the sf2 coding standards, but that is another matter.

I saw another pull request that was not merged but didn't try it. There were no commits for a long time for this bundle. Is it still continued?

compatibility with symfony2.1 increased, unit tests working
bootstrap file was outdated and I fixtures as much as I needed to
run the bundle again. There is still a lot of deprecated functions that
need to be fixed, but that is some work and requires time I did not have
atm...
@vslinko

This comment has been minimized.

Show comment Hide comment
@vslinko

vslinko Sep 16, 2012

+1 (!)

vslinko commented Sep 16, 2012

+1 (!)

DavidBadura added a commit that referenced this pull request Sep 19, 2012

Merge pull request #35 from wwwdata/symfony2.1
compatibility with symfony2.1 increased, unit tests working

@DavidBadura DavidBadura merged commit bf928b4 into simplethings:master Sep 19, 2012

@mrbase

This comment has been minimized.

Show comment Hide comment
@mrbase

mrbase Dec 3, 2012

Contributor

this breaks bc with 2.0

this breaks bc with 2.0

@mrbase

This comment has been minimized.

Show comment Hide comment
@mrbase

mrbase Dec 3, 2012

Contributor

this breaks bc with 2.0

Contributor

mrbase commented on Form/Type/ImageType.php in 3560738 Dec 3, 2012

this breaks bc with 2.0

@mrbase

This comment has been minimized.

Show comment Hide comment
@mrbase

mrbase Dec 3, 2012

Contributor

this breaks bc with 2.0

Contributor

mrbase commented on Form/Type/FileSetType.php in 3560738 Dec 3, 2012

this breaks bc with 2.0

@mrbase

This comment has been minimized.

Show comment Hide comment
@mrbase

mrbase Dec 3, 2012

Contributor

this breaks bc with 2.0

this breaks bc with 2.0

This comment has been minimized.

Show comment Hide comment
@stof

stof Dec 3, 2012

Contributor

@mrbase it is impossible to implement the 2.0 and the 2.1 interfaces at the same time. Use an older version of the bundle

Contributor

stof replied Dec 3, 2012

@mrbase it is impossible to implement the 2.0 and the 2.1 interfaces at the same time. Use an older version of the bundle

@mrbase

This comment has been minimized.

Show comment Hide comment
@mrbase

mrbase Dec 3, 2012

Contributor

perhaps there should be seperate branches for sf 2.1 an sf 2.1

Contributor

mrbase commented on 3560738 Dec 3, 2012

perhaps there should be seperate branches for sf 2.1 an sf 2.1

This comment has been minimized.

Show comment Hide comment
@stof

stof Dec 3, 2012

Contributor

there is a v0.1 tag for Symfony 2.0

Contributor

stof replied Dec 3, 2012

there is a v0.1 tag for Symfony 2.0

This comment has been minimized.

Show comment Hide comment
@mrbase

mrbase Dec 3, 2012

Contributor

bah, didn't see that one ... sorry works

  • i will create a pull request with updated docs as soon as i have a minute
Contributor

mrbase replied Dec 3, 2012

bah, didn't see that one ... sorry works

  • i will create a pull request with updated docs as soon as i have a minute
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment