From e37615373243d3e3a7c12eb3d9f392ea477887d3 Mon Sep 17 00:00:00 2001 From: Angel Cervera Claudio <293444+angelcervera@users.noreply.github.com> Date: Fri, 13 Nov 2020 18:38:25 +0000 Subject: [PATCH 1/7] Remove not necessary TODOs and FIXMEs. --- .../com/acervera/osm4scala/model/RelationMemberEntity.scala | 1 - .../src/main/scala/com/acervera/osm4scala/model/WayEntity.scala | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/core/src/main/scala/com/acervera/osm4scala/model/RelationMemberEntity.scala b/core/src/main/scala/com/acervera/osm4scala/model/RelationMemberEntity.scala index 637025f..b02325e 100644 --- a/core/src/main/scala/com/acervera/osm4scala/model/RelationMemberEntity.scala +++ b/core/src/main/scala/com/acervera/osm4scala/model/RelationMemberEntity.scala @@ -33,5 +33,4 @@ object RelationMemberEntityTypes extends Enumeration { val Unrecognized = Value(3) } -// FIXME: relationTypes should be singular instead plural. case class RelationMemberEntity(id: Long, relationTypes: RelationMemberEntityTypes.Value, role: String) diff --git a/core/src/main/scala/com/acervera/osm4scala/model/WayEntity.scala b/core/src/main/scala/com/acervera/osm4scala/model/WayEntity.scala index ba46a30..9cd4556 100644 --- a/core/src/main/scala/com/acervera/osm4scala/model/WayEntity.scala +++ b/core/src/main/scala/com/acervera/osm4scala/model/WayEntity.scala @@ -35,7 +35,7 @@ case class WayEntity(id: Long, nodes: Seq[Long], tags: Map[String, String]) exte override val osmModel: OSMTypes.Value = OSMTypes.Way - object WayEntityTypes extends Enumeration { // TODO: How to know the type ????? + object WayEntityTypes extends Enumeration { val Open, Close, Area, CombinedClosedPolylineArea = Value } From 047bb8f7f1e881338dee5d942e7d4b71293ad648 Mon Sep 17 00:00:00 2001 From: Angel Cervera Claudio <293444+angelcervera@users.noreply.github.com> Date: Fri, 13 Nov 2020 18:39:01 +0000 Subject: [PATCH 2/7] Add badge --- README.md | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index cb1b70e..eb8941f 100644 --- a/README.md +++ b/README.md @@ -2,10 +2,11 @@ [![Build Status](https://travis-ci.com/simplexspatial/osm4scala.svg?branch=master)](https://travis-ci.com/simplexspatial/osm4scala) [![Coverage Status](https://coveralls.io/repos/github/simplexspatial/osm4scala/badge.svg?branch=master)](https://coveralls.io/github/simplexspatial/osm4scala?branch=master) +[![Quality gate](https://sonarcloud.io/api/project_badges/quality_gate?project=simplexspatial_osm4scala)](https://sonarcloud.io/dashboard?id=simplexspatial_osm4scala) [![Gitter](https://img.shields.io/gitter/room/osm4scala/talk.svg)](https://gitter.im/osm4scala/talk) [![MIT licensed](https://img.shields.io/badge/license-MIT-blue.svg)](https://raw.githubusercontent.com/angelcervera/osm4scala/master/LICENSE.md) [![FOSSA Status](https://app.fossa.com/api/projects/git%2Bgithub.com%2Fangelcervera%2Fosm4scala.svg?type=shield)](https://app.fossa.com/projects/git%2Bgithub.com%2Fangelcervera%2Fosm4scala?ref=badge_shield) -[![Contributor Covenant](https://img.shields.io/badge/Contributor%20Covenant-v2.0%20adopted-ff69b4.svg)](code_of_conduct.md) + **Scala library** and **Spark Connector** focus on parsing [PBF2 OpenStreetMap files](https://wiki.openstreetmap.org/wiki/PBF_Format) as iterators. @@ -446,6 +447,8 @@ For free community support, there are two channels: ## Contributing +[![Contributor Covenant](https://img.shields.io/badge/Contributor%20Covenant-v2.0%20adopted-ff69b4.svg)](code_of_conduct.md) + First of all, if you arrived to this point, thanks for at least think about contributing!!! ### Way to contribute From d3b8622f370f86361355709689d9f7a3e4e3ea98 Mon Sep 17 00:00:00 2001 From: Angel Cervera Claudio <293444+angelcervera@users.noreply.github.com> Date: Fri, 13 Nov 2020 18:40:30 +0000 Subject: [PATCH 3/7] typo --- .../main/scala/com/acervera/osm4scala/spark/OSMDataFinder.scala | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spark/src/main/scala/com/acervera/osm4scala/spark/OSMDataFinder.scala b/spark/src/main/scala/com/acervera/osm4scala/spark/OSMDataFinder.scala index d4b4d47..00da8f8 100644 --- a/spark/src/main/scala/com/acervera/osm4scala/spark/OSMDataFinder.scala +++ b/spark/src/main/scala/com/acervera/osm4scala/spark/OSMDataFinder.scala @@ -57,7 +57,7 @@ object OSMDataFinder { * Check that It's OSMData string and a true block as well. * @return */ - def isFalsePositive(): Boolean = false // TODO: Need implementation. + def isFalsePositive(): Boolean = false // TODO: Needs implementation. /** * Read next n bytes from the stream. If are not enough, return None. From 13b698a8e2f6bcf4ee2352e5a14111a2d9a022f9 Mon Sep 17 00:00:00 2001 From: Angel Cervera Claudio <293444+angelcervera@users.noreply.github.com> Date: Fri, 13 Nov 2020 19:07:35 +0000 Subject: [PATCH 4/7] Generate coverage report. --- .github/workflows/scala.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/scala.yml b/.github/workflows/scala.yml index 0d3644d..e212880 100644 --- a/.github/workflows/scala.yml +++ b/.github/workflows/scala.yml @@ -14,4 +14,6 @@ jobs: with: java-version: 1.8 - name: Run tests - run: sbt +test + run: sbt clean coverage test + - name: Report coverage + run: sbt coverageAggregate \ No newline at end of file From 9e0b8d89a26002997943ed81507c2aa68375c608 Mon Sep 17 00:00:00 2001 From: Angel Cervera Claudio <293444+angelcervera@users.noreply.github.com> Date: Fri, 13 Nov 2020 19:19:52 +0000 Subject: [PATCH 5/7] One report per project --- .github/workflows/scala.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/scala.yml b/.github/workflows/scala.yml index e212880..742ffd0 100644 --- a/.github/workflows/scala.yml +++ b/.github/workflows/scala.yml @@ -16,4 +16,4 @@ jobs: - name: Run tests run: sbt clean coverage test - name: Report coverage - run: sbt coverageAggregate \ No newline at end of file + run: sbt coverageReport \ No newline at end of file From b811f0d73da8d54683566d063711a2d9b2e63432 Mon Sep 17 00:00:00 2001 From: Angel Cervera Claudio <293444+angelcervera@users.noreply.github.com> Date: Sun, 15 Nov 2020 17:39:40 +0000 Subject: [PATCH 6/7] Add return line at the EOF --- .github/workflows/scala.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/scala.yml b/.github/workflows/scala.yml index 742ffd0..428ef90 100644 --- a/.github/workflows/scala.yml +++ b/.github/workflows/scala.yml @@ -16,4 +16,4 @@ jobs: - name: Run tests run: sbt clean coverage test - name: Report coverage - run: sbt coverageReport \ No newline at end of file + run: sbt coverageReport From 970e6f98e95af6da2f753be257fb994ccecc3d98 Mon Sep 17 00:00:00 2001 From: Angel Cervera Claudio <293444+angelcervera@users.noreply.github.com> Date: Sun, 15 Nov 2020 17:47:08 +0000 Subject: [PATCH 7/7] No coverage integration at the moment. --- .github/workflows/scala.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/scala.yml b/.github/workflows/scala.yml index 428ef90..0d3644d 100644 --- a/.github/workflows/scala.yml +++ b/.github/workflows/scala.yml @@ -14,6 +14,4 @@ jobs: with: java-version: 1.8 - name: Run tests - run: sbt clean coverage test - - name: Report coverage - run: sbt coverageReport + run: sbt +test