Gpgwt 74 plugin modules #8

Merged
merged 2 commits into from Apr 19, 2012

Conversation

Projects
None yet
2 participants
@johnrellis
Contributor

johnrellis commented Apr 19, 2012

Hey David,

I simply added some lines of code to _GwtInternal to make it possible to include gwt source from plugins defined in BuildConfig.groovy

gwt {
local.workers = 3
plugins = ['reporting']
run.args = {
jvmarg(value: '-Xmx1024m')
}
}

It does not fill the request of including the "SomeGwtLibrary.jar" that we talked about in our email thread, just the source code.

PluginApp
SomeGwtLibrary.jar
src/gwt/SomeClass.java

Secondly, the dto plugin is still handled separately as the .gwt.xml file for this is in the GWT plugin itself which I find a little confusing. If you want to handle the dto plugin the same as the rest I can definitely change the code to try that (if possible without breaking the dto plugin)

@dawsonsystems

This comment has been minimized.

Show comment Hide comment
@dawsonsystems

dawsonsystems Apr 19, 2012

Contributor

I think we can split the lib question to be a different problem as the dependency management will need revisiting at some point anyway.
Similar with the dto plugin, I wouldn't want to break functionality for anyone using it already, so lets leave the auto detection where it is.

I'm going to clean up a few of the outstanding issues and make a new release over the next couple of days, this will make a great addition (probably the most important!)

Thanks!

Contributor

dawsonsystems commented Apr 19, 2012

I think we can split the lib question to be a different problem as the dependency management will need revisiting at some point anyway.
Similar with the dto plugin, I wouldn't want to break functionality for anyone using it already, so lets leave the auto detection where it is.

I'm going to clean up a few of the outstanding issues and make a new release over the next couple of days, this will make a great addition (probably the most important!)

Thanks!

@dawsonsystems

This comment has been minimized.

Show comment Hide comment
@dawsonsystems

dawsonsystems Apr 19, 2012

Contributor

Once I have the other fixes ready i'll merge them all to master and release, so this pull will remain open for now.

Contributor

dawsonsystems commented Apr 19, 2012

Once I have the other fixes ready i'll merge them all to master and release, so this pull will remain open for now.

@johnrellis

This comment has been minimized.

Show comment Hide comment
@johnrellis

johnrellis Apr 19, 2012

Contributor

Great. I will keep an eye out as this is needed for my current project in work. I am using the locally built plugin in my current project and it is humming away. Thanks for help with my first possible commit :)

Contributor

johnrellis commented Apr 19, 2012

Great. I will keep an eye out as this is needed for my current project in work. I am using the locally built plugin in my current project and it is humming away. Thanks for help with my first possible commit :)

@johnrellis

This comment has been minimized.

Show comment Hide comment
@johnrellis

johnrellis Apr 19, 2012

Contributor

Also if I can add to the docs if they exist??

Contributor

johnrellis commented Apr 19, 2012

Also if I can add to the docs if they exist??

dawsonsystems added a commit that referenced this pull request Apr 19, 2012

@dawsonsystems dawsonsystems merged commit 54c56b2 into simplicityitself:master Apr 19, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment