Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Gpgwt 74 plugin modules #8
Conversation
johnrellis
added some commits
Apr 19, 2012
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
dawsonsystems
Apr 19, 2012
Contributor
I think we can split the lib question to be a different problem as the dependency management will need revisiting at some point anyway.
Similar with the dto plugin, I wouldn't want to break functionality for anyone using it already, so lets leave the auto detection where it is.
I'm going to clean up a few of the outstanding issues and make a new release over the next couple of days, this will make a great addition (probably the most important!)
Thanks!
I think we can split the lib question to be a different problem as the dependency management will need revisiting at some point anyway. I'm going to clean up a few of the outstanding issues and make a new release over the next couple of days, this will make a great addition (probably the most important!) Thanks! |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
dawsonsystems
Apr 19, 2012
Contributor
Once I have the other fixes ready i'll merge them all to master and release, so this pull will remain open for now.
Once I have the other fixes ready i'll merge them all to master and release, so this pull will remain open for now. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
johnrellis
Apr 19, 2012
Contributor
Great. I will keep an eye out as this is needed for my current project in work. I am using the locally built plugin in my current project and it is humming away. Thanks for help with my first possible commit :)
Great. I will keep an eye out as this is needed for my current project in work. I am using the locally built plugin in my current project and it is humming away. Thanks for help with my first possible commit :) |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
Also if I can add to the docs if they exist?? |
johnrellis commentedApr 19, 2012
Hey David,
I simply added some lines of code to _GwtInternal to make it possible to include gwt source from plugins defined in BuildConfig.groovy
gwt {
local.workers = 3
plugins = ['reporting']
run.args = {
jvmarg(value: '-Xmx1024m')
}
}
It does not fill the request of including the "SomeGwtLibrary.jar" that we talked about in our email thread, just the source code.
PluginApp
SomeGwtLibrary.jar
src/gwt/SomeClass.java
Secondly, the dto plugin is still handled separately as the .gwt.xml file for this is in the GWT plugin itself which I find a little confusing. If you want to handle the dto plugin the same as the rest I can definitely change the code to try that (if possible without breaking the dto plugin)