Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

extended search functionality #2

Closed
wants to merge 5 commits into
from

Conversation

Projects
None yet
3 participants

qw3r commented Jul 30, 2012

No description provided.

Istvan DEMETER added some commits Jul 27, 2012

Owner

lukaso commented Aug 8, 2012

@qw3r Sorry for lack of response. I've been waiting for this pull request to be merged into the upstream repo, and there's a pull request there that implements almost exactly the same things as you have. But given these pull requests are piling up, might be best to wait a bit. Here is the pull request: elia#17

Owner

pvdb commented Aug 17, 2012

@qw3r - as a general comment, I'd argue that renaming classes (and hence files that are under git control) should be done as a separate pull request, as it is now very hard to review the entire diff, forcing a commit-by-commit review.

A separate pull request for the renaming with no actual functional changes would be better, IMO... thanks!

qw3r commented Aug 22, 2012

Hello guys,

sorry for not replying until now.
thanks you for your notices, comments on the PR i very appreciate it. I have to work on other things, but i'll keep an eye on this great project, which helped me a lot. Thanks!

@qw3r qw3r closed this Aug 22, 2012

Owner

lukaso commented Aug 22, 2012

@qw3r No problem. Thanks for contributing. It really looks like the pull requests got stuck over at the original.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment