Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(package): map TS types explicitly #48

Merged

Conversation

char0n
Copy link
Contributor

@char0n char0n commented Aug 25, 2021

Refs #46

This PR is alternative approach to #46

@ColdtQ
Copy link

ColdtQ commented Aug 25, 2021

Refs #46

This PR is alternative approach to #46

I'm going to close my PR, this is a much better solution.

@ColdtQ
Copy link

ColdtQ commented Aug 28, 2021

@char0n Can you request a review from maintainer?

@ColdtQ
Copy link

ColdtQ commented Aug 29, 2021

@jeanlescure

@char0n
Copy link
Contributor Author

char0n commented Aug 29, 2021

@ColdtQ I’d say I already did by issuing this PR :)

@jeanlescure
Copy link
Collaborator

Thanks for the contribution @char0n and @ColdtQ ! 🚀

I tested further and found the following case where types were being inferred rather than being defined by the .d.ts:

Screenshot_20210829_143403

Changing the build so that the .d.ts file matches the name of the output .js file solves this issue:

Screenshot_20210829_143530

I feel silly for not having noticed that the generated .d.ts filename did not match the library's output .js file 😅

@jeanlescure jeanlescure merged commit a1dd16a into simplyhexagonal:main Aug 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants