optionally name a form that is present on pages with different URLs #27

Merged
merged 3 commits into from May 14, 2012

Conversation

Projects
None yet
2 participants
@mdespuits
Contributor

mdespuits commented May 8, 2012

I was running into an issue with a dynamic page which loaded the same form in multiple places (one in a sliding tab within on URL and another in a static page). This fix allows identical forms in different locations to share the same localStorage info.

@simsalabim

This comment has been minimized.

Show comment Hide comment
@simsalabim

simsalabim May 11, 2012

Owner

Great, @mattdbridges! But could you please provide tests for this feature?
Thanks.

Owner

simsalabim commented May 11, 2012

Great, @mattdbridges! But could you please provide tests for this feature?
Thanks.

@mdespuits

This comment has been minimized.

Show comment Hide comment
@mdespuits

mdespuits May 11, 2012

Contributor

Are these tests sufficient, @simsalabim?

Contributor

mdespuits commented May 11, 2012

Are these tests sufficient, @simsalabim?

@mdespuits

This comment has been minimized.

Show comment Hide comment
@mdespuits

mdespuits May 11, 2012

Contributor

One other question.

In SpecRunner.html, you reference js/sisyphus.js. Wouldn't it just be sisyphus.js? There is no js dir.

Contributor

mdespuits commented May 11, 2012

One other question.

In SpecRunner.html, you reference js/sisyphus.js. Wouldn't it just be sisyphus.js? There is no js dir.

simsalabim added a commit that referenced this pull request May 14, 2012

Merge pull request #27 from mattdbridges/named_forms
optionally name a form that is present on pages with different URLs

@simsalabim simsalabim merged commit 1dc5791 into simsalabim:master May 14, 2012

simsalabim added a commit that referenced this pull request May 14, 2012

@simsalabim

This comment has been minimized.

Show comment Hide comment
@simsalabim

simsalabim May 14, 2012

Owner

@mattdbridges brilliant, thanks!
Yes, you're right, I've made a fix - that was because I used to test it in a separate branch and just copied SpecRunner into master.

Owner

simsalabim commented May 14, 2012

@mattdbridges brilliant, thanks!
Yes, you're right, I've made a fix - that was because I used to test it in a separate branch and just copied SpecRunner into master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment