Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build on FreeBSD with GCC #193

Closed
wants to merge 1 commit into from
Closed

Fix build on FreeBSD with GCC #193

wants to merge 1 commit into from

Conversation

pkubaj
Copy link
Contributor

@pkubaj pkubaj commented Oct 9, 2018

This is required for architectures that still use GCC (as opposed to those using Clang).

@pkubaj
Fix build on FreeBSD with GCC
f72527f 
This is required for architectures that still use GCC (as opposed to those using Clang)
simsong
simsong reviewed Oct 9, 2018
View reviewed changes
Copy link
Owner

@simsong simsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that the correct way to do this is to check for param.h in the autoconf and then to say ifdef HAVE_SYS_PARAM_H rather than #ifdef __FreeBSD__

simsong
simsong requested changes Oct 20, 2018
View reviewed changes
Copy link
Owner

@simsong simsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please explicitly test for the required include file, rather than assuming that it is present just because you are compiling on FreeBSD.

@simsong
Copy link
Owner

simsong commented Oct 20, 2018

Please resubmit.

@simsong simsong closed this Oct 20, 2018
@pkubaj pkubaj deleted the patch-1 branch October 22, 2018 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simsong simsong simsong requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pkubaj @simsong