JSX style is unreadable and too dark #22

Open
dbkaplun opened this Issue Nov 19, 2016 · 9 comments

Projects

None yet

2 participants

@simurai
Owner
simurai commented Nov 22, 2016

@dbkaplun Thanks for example code and screenshot.. that's very helpful.

Just another question: What's the language package you are using? I can see the grammar as `JavaScript (JSX).

@simurai simurai added the enhancement label Nov 22, 2016
@dbkaplun

I'm using linter-jsxhint@0.1.2, is that what you mean? That's the only package I see when I search for "jsx" in the Packages tab of Settings. Maybe it's built-in?

@simurai
Owner
simurai commented Nov 22, 2016

linter-jsxhint@0.1.2 shouldn't do syntax highlighting. Do you have https://atom.io/packages/language-babel. It has jsx support and is quite popular.

@dbkaplun

I have package react@0.16.1, maybe that's it? It's way too dark with .js as well. I'll attach a screenshot when I get the chance.

@simurai
Owner
simurai commented Nov 22, 2016

Yes, react is probably it. I'll try it out with your sample code and see why it's so dark.

@dbkaplun

Here's some nice dark JS code
screen shot 2016-11-25 at 5 45 42 pm

@simurai
Owner
simurai commented Nov 26, 2016

Ok, this should be improved with #21 and published as 2.0.1.

screen shot 2016-11-26 at 10 25 56 pm

@simurai simurai closed this Nov 26, 2016
@dbkaplun

Definitely looks a little better, still very dark though (specifically punctuation and builtins like moveTo and Math.sin). Even linesCtx is very dark. It's a shame because this is my favorite theme and I hate having to use other themes. Should I open another issue? Looks like your Atom is significantly redder than mine.. on your screen, beginPath is white and on mine it's lavender. Maybe that has something to do with it?
screen shot 2016-11-26 at 9 20 32 am

@simurai
Owner
simurai commented Nov 28, 2016

Looks like your Atom is significantly redder than mine.. on your screen, beginPath is white and on mine it's lavender. Maybe that has something to do with it?

In DuoTone dark you can now change the colors in the settings, see: https://github.com/simurai/duotone-dark-syntax#settings So you could brighten everything.

I'll see about brightening the default since that seems a bit dark.

@simurai simurai reopened this Nov 28, 2016
@simurai simurai added a commit to simurai/duotone-dark-syntax that referenced this issue Nov 28, 2016
@simurai Increase default brightness 2fab50b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment