New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement shorthand for ({foo}|{bar}) pattern #43

Merged
merged 1 commit into from Mar 5, 2016

Conversation

Projects
None yet
2 participants
@namusyaka
Member

namusyaka commented Jun 20, 2015

ref #42
I've tried to implement shorthand for the pattern.
I'm not sure what this approach is best, but this will work correctly.
@rkh Can you review this?

@rkh

This comment has been minimized.

Show comment
Hide comment
@rkh

rkh Jul 15, 2015

Member

Looks good. Will merge when I get around to prepping the next release.

Member

rkh commented Jul 15, 2015

Looks good. Will merge when I get around to prepping the next release.

@rkh

This comment has been minimized.

Show comment
Hide comment
@rkh

rkh Jul 15, 2015

Member

Thank you. :)

Member

rkh commented Jul 15, 2015

Thank you. :)

@namusyaka

This comment has been minimized.

Show comment
Hide comment
@namusyaka

namusyaka Oct 17, 2015

Member

@rkh ping?

Member

namusyaka commented Oct 17, 2015

@rkh ping?

namusyaka added a commit that referenced this pull request Mar 5, 2016

Merge pull request #43 from namusyaka/implement-shorthand
Implement shorthand for ({foo}|{bar}) pattern
Closes #42

@namusyaka namusyaka merged commit 9611951 into sinatra:master Mar 5, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@namusyaka namusyaka deleted the namusyaka:implement-shorthand branch Mar 5, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment