New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Mustermann::Grape #46

Merged
merged 5 commits into from Mar 1, 2016

Conversation

Projects
None yet
2 participants
@namusyaka
Member

namusyaka commented Feb 27, 2016

@rkh I'd like to use Mustermann in the new router of Grape.
I've already implemented this class in mustermann19.

Could you merge this into your central repo?

@namusyaka namusyaka changed the title from Implement Mustermann::Grape to [WIP] Implement Mustermann::Grape Feb 27, 2016

@rkh

This comment has been minimized.

Show comment
Hide comment
@rkh

rkh Feb 28, 2016

Member

👍 looks good. Will have to figure out what's up with the travis setup.

I'd like to give you a commit bit. We'll also move Mustermann from being a personal project of mine to being part for the Sinatra org soon.

Member

rkh commented Feb 28, 2016

👍 looks good. Will have to figure out what's up with the travis setup.

I'd like to give you a commit bit. We'll also move Mustermann from being a personal project of mine to being part for the Sinatra org soon.

@namusyaka

This comment has been minimized.

Show comment
Hide comment
@namusyaka

namusyaka Feb 28, 2016

Member

Thank you for your kindness!
I'd like to collaborate to maintenance!

Member

namusyaka commented Feb 28, 2016

Thank you for your kindness!
I'd like to collaborate to maintenance!

@namusyaka

This comment has been minimized.

Show comment
Hide comment
@namusyaka

namusyaka Feb 29, 2016

Member

@rkh I've just fixed some points. Also, this hansi pull request will fix the error of ruby-2.2.
Could you merge the pull request?

Member

namusyaka commented Feb 29, 2016

@rkh I've just fixed some points. Also, this hansi pull request will fix the error of ruby-2.2.
Could you merge the pull request?

@namusyaka namusyaka changed the title from [WIP] Implement Mustermann::Grape to Implement Mustermann::Grape Feb 29, 2016

@namusyaka

This comment has been minimized.

Show comment
Hide comment
@namusyaka

namusyaka Mar 1, 2016

Member

@rkh Fixed. All tests have been successful now.

Member

namusyaka commented Mar 1, 2016

@rkh Fixed. All tests have been successful now.

rkh added a commit that referenced this pull request Mar 1, 2016

@rkh rkh merged commit f99197f into sinatra:master Mar 1, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@namusyaka

This comment has been minimized.

Show comment
Hide comment
@namusyaka

namusyaka Mar 2, 2016

Member

Thank you for merging! :)

Member

namusyaka commented Mar 2, 2016

Thank you for merging! :)

@namusyaka namusyaka deleted the namusyaka:implement-grape-pattern branch Mar 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment