Move the following gems to a single meta gem, called mustermann-contrib: #53

Merged
merged 2 commits into from Aug 22, 2016

Conversation

Projects
None yet
2 participants
@zzak
Member

zzak commented Aug 17, 2016

  • mustermann-cake
  • mustermann-express
  • mustermann-fileutils
  • mustermann-flask
  • mustermann-grape
  • mustermann-pyramid
  • mustermann-rails
  • mustermann-shell
  • mustermann-simple
  • mustermann-strscan
  • mustermann-uri-template
  • mustermann-visualizer

We will no longer support mustermann-everything instead, this gem replaces it.

@namusyaka

This comment has been minimized.

Show comment
Hide comment
@namusyaka

namusyaka Aug 17, 2016

Member

Why do you want to move gems to the single meta gem?
I don't think this is reasonable because this change makes require the all unnecessary code even if developer would like to use mustermann-simple.
I think all mustermann patterns should be separated as a gem.

Member

namusyaka commented Aug 17, 2016

Why do you want to move gems to the single meta gem?
I don't think this is reasonable because this change makes require the all unnecessary code even if developer would like to use mustermann-simple.
I think all mustermann patterns should be separated as a gem.

Move the following gems to a single meta gem, called mustermann-contrib:
* mustermann-cake
* mustermann-express
* mustermann-fileutils
* mustermann-flask
* mustermann-grape
* mustermann-pyramid
* mustermann-rails
* mustermann-shell
* mustermann-simple
* mustermann-strscan
* mustermann-uri-template
* mustermann-visualizer

We will no longer support mustermann-everything instead, this gem replaces it.
@zzak

This comment has been minimized.

Show comment
Hide comment
@zzak

zzak Aug 17, 2016

Member

@namusyaka After talking with @rkh about this, he suggested to combine the extra plugins to make release maintenance easier.

This change wouldn't be included until Mustermann 1.0.0, which I will cut once this is done.

The argument is most of these plugins are really small, and aren't autoloaded so the only would be disk space and network bandwidth when installing the gem. However, it's fair to assume most applications have tens if not hundreds of dependencies already, and this would actually cut down the number of packages required to download and install. As well, the real win here, is that I only have to cut 2 gems to release all of Mustermann and going forward is a much more sustainable strategy.

Member

zzak commented Aug 17, 2016

@namusyaka After talking with @rkh about this, he suggested to combine the extra plugins to make release maintenance easier.

This change wouldn't be included until Mustermann 1.0.0, which I will cut once this is done.

The argument is most of these plugins are really small, and aren't autoloaded so the only would be disk space and network bandwidth when installing the gem. However, it's fair to assume most applications have tens if not hundreds of dependencies already, and this would actually cut down the number of packages required to download and install. As well, the real win here, is that I only have to cut 2 gems to release all of Mustermann and going forward is a much more sustainable strategy.

@zzak

This comment has been minimized.

Show comment
Hide comment
@zzak

zzak Aug 17, 2016

Member

Also, I think this is OK to merge if everyone is happy and then I can cut a pre-release of Mustermann 1.0!

Member

zzak commented Aug 17, 2016

Also, I think this is OK to merge if everyone is happy and then I can cut a pre-release of Mustermann 1.0!

@namusyaka

This comment has been minimized.

Show comment
Hide comment
@namusyaka

namusyaka Aug 18, 2016

Member

@zzak Hmm, makes sense.
Thanks for the thorough explanation.
I don't intend to deny the approach already if having obtained a consensus.

Member

namusyaka commented Aug 18, 2016

@zzak Hmm, makes sense.
Thanks for the thorough explanation.
I don't intend to deny the approach already if having obtained a consensus.

@zzak

This comment has been minimized.

Show comment
Hide comment
@zzak

zzak Aug 19, 2016

Member

@namusyaka If there's any gem included here you'd like to take over (such as mustermann-grape), I'm happy to leave it out and you're free to maintain it separately.

Member

zzak commented Aug 19, 2016

@namusyaka If there's any gem included here you'd like to take over (such as mustermann-grape), I'm happy to leave it out and you're free to maintain it separately.

@zzak zzak merged commit 650e271 into master Aug 22, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@zzak zzak deleted the mustermann-contrib branch Aug 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment