New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Tempfile reference being returned as nil #99

Merged
merged 1 commit into from Jul 26, 2016

Conversation

Projects
None yet
2 participants
@droppedoncaprica
Contributor

droppedoncaprica commented Sep 30, 2015

This PR fixes the issue of files being uploaded from users having
the params[:file][:tempfile] being returned as nil, rather than
an instance of Tempfile like it should be.

PR fixes #90, and shamelessly stolen from #91. This PR does
not contain the warnings that were included in #91.

Thanks for the fix @danleyden! Hopefully this will not have a
failing Travis.ci build.

Fix Tempfile reference being returned as nil
This PR fixes the issue of files being uploaded from users having
the params[:file][:tempfile] being returned as `nil`, rather than
an instance of Tempfile like it should be.

PR fixes #90, and shamelessly stolen from #91.
@droppedoncaprica

This comment has been minimized.

Show comment
Hide comment
@droppedoncaprica

droppedoncaprica Sep 30, 2015

Contributor

And the build failed! I'll investigate it a bit, let me know if there's something obvious that I need to do here.

Contributor

droppedoncaprica commented Sep 30, 2015

And the build failed! I'll investigate it a bit, let me know if there's something obvious that I need to do here.

@zzak zzak reopened this Jul 26, 2016

@zzak zzak merged commit bce9100 into sinatra:master Jul 26, 2016

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@zzak

This comment has been minimized.

Show comment
Hide comment
@zzak

zzak Jul 26, 2016

Member

@droppedoncaprica Thank you!!

Member

zzak commented Jul 26, 2016

@droppedoncaprica Thank you!!

zzak added a commit that referenced this pull request Aug 12, 2016

Merge pull request #99 from droppedoncaprica/tempFileFix
Fix Tempfile reference being returned as nil
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment