Sinatra master breaks namespace spec #200

Closed
zzak opened this Issue May 4, 2016 · 4 comments

Projects

None yet

2 participants

@zzak
Member
zzak commented May 4, 2016
  1. $ sinatra=master bundle
  2. $ sinatra=master bundle exec rake spec

Produces the following errors:

Failures:

  1) Sinatra::Namespace HTTP GET error handling falls back to the handler defined in the base app
     Failure/Error: last_response.body.should        eq 'nicht gefunden' unless verb == :head

       expected: "nicht gefunden"
            got: "not found..."

       (compared using ==)
     # ./spec/namespace_spec.rb:515:in `block (5 levels) in <top (required)>'

  2) Sinatra::Namespace HTTP POST error handling falls back to the handler defined in the base app
     Failure/Error: last_response.body.should        eq 'nicht gefunden' unless verb == :head

       expected: "nicht gefunden"
            got: "not found..."

       (compared using ==)
     # ./spec/namespace_spec.rb:515:in `block (5 levels) in <top (required)>'

  3) Sinatra::Namespace HTTP PUT error handling falls back to the handler defined in the base app
     Failure/Error: last_response.body.should        eq 'nicht gefunden' unless verb == :head

       expected: "nicht gefunden"
            got: "not found..."

       (compared using ==)
     # ./spec/namespace_spec.rb:515:in `block (5 levels) in <top (required)>'

  4) Sinatra::Namespace HTTP DELETE error handling falls back to the handler defined in the base app
     Failure/Error: last_response.body.should        eq 'nicht gefunden' unless verb == :head

       expected: "nicht gefunden"
            got: "not found..."

       (compared using ==)
     # ./spec/namespace_spec.rb:515:in `block (5 levels) in <top (required)>'

  5) Sinatra::Namespace HTTP OPTIONS error handling falls back to the handler defined in the base app
     Failure/Error: last_response.body.should        eq 'nicht gefunden' unless verb == :head

       expected: "nicht gefunden"
            got: "not found..."

       (compared using ==)
     # ./spec/namespace_spec.rb:515:in `block (5 levels) in <top (required)>'

  6) Sinatra::Namespace HTTP PATCH error handling falls back to the handler defined in the base app
     Failure/Error: last_response.body.should        eq 'nicht gefunden' unless verb == :head

       expected: "nicht gefunden"
            got: "not found..."

       (compared using ==)
     # ./spec/namespace_spec.rb:515:in `block (5 levels) in <top (required)>'

Finished in 4.23 seconds
856 examples, 6 failures

travis log

@zzak
Member
zzak commented May 5, 2016 edited

Essentially all of the namespace tests fail now: https://travis-ci.org/sinatra/sinatra-contrib/jobs/127980688

Even more so because of sinatra/sinatra#1086

@stjhimy
Contributor
stjhimy commented Jun 21, 2016

I will work on this next week, it seems still failing with Sinatra master.

@zzak
Member
zzak commented Jun 23, 2016

@stjhimy Any help is appreciated here! This is the major blocker atm

@zzak zzak added this to the 2.0.0 milestone Jun 23, 2016
@zzak zzak referenced this issue in sinatra/sinatra Jul 11, 2016
Closed

Plan for Rails 5.0 compatible release? #1135

@zzak
Member
zzak commented Jul 16, 2016

Fixed by #207

@zzak zzak closed this Jul 16, 2016
@zzak zzak added a commit that referenced this issue Jul 19, 2016
@zzak zzak Use Mustermann from master until a release is made
Since master has a patch which fixes the missing `:+` implementation for
Regular and Sinatra-based patterns.

We can also re-enable the namespace specs for accepting regular expressions for
path concatination.

/cc #200 and #207
9500d76
@zzak zzak added a commit to zzak/sinatra-contrib that referenced this issue Jul 22, 2016
@zzak zzak Skip failing Namespace related specs /cc #200 eedc923
@zzak zzak added a commit to zzak/sinatra-contrib that referenced this issue Jul 22, 2016
@zzak zzak Use Mustermann from master until a release is made
Since master has a patch which fixes the missing `:+` implementation for
Regular and Sinatra-based patterns.

We can also re-enable the namespace specs for accepting regular expressions for
path concatination.

/cc #200 and #207
b1fd9f1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment